Skip to content

Trivial: Fix obvious assignment/equality error in test #8673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Sep 7, 2016
Merged

Trivial: Fix obvious assignment/equality error in test #8673

maflcko merged 1 commit into from
Sep 7, 2016

Conversation

@JeremyRubin
Copy link
Contributor

@JeremyRubin JeremyRubin commented Sep 6, 2016

I think this was incorrect; may as well correct it.

@sipa
Copy link
Member

sipa commented Sep 6, 2016

utACK

@fanquake fanquake added the Tests label Sep 7, 2016
@fanquake
Copy link
Member

fanquake commented Sep 7, 2016

The Travis failure is unrelated.

segwit.py:
Initializing test directory /tmp/testa3q5cowz/31
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
Verify sigops are counted in GBT with pre-BIP141 rules before the fork
Assertion failed: 199.99600000 != 999.980
Stopping nodes
Not cleaning up dir /tmp/testa3q5cowz/31
Failed
stderr:
   File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 150, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/segwit.py", line 166, in run_test
    assert_equal(self.nodes[2].getbalance(), 20*Decimal("49.999"))
  File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/util.py", line 504, in assert_equal
    raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
Pass: False, Duration: 3 s

@dcousens
Copy link
Contributor

dcousens commented Sep 7, 2016

utACK 426e7bc

@paveljanik
Copy link
Contributor

paveljanik commented Sep 7, 2016

utACK 426e7bc

@maflcko
Copy link
Member

maflcko commented Sep 7, 2016

Good catch! utACK 426e7bc

@maflcko maflcko merged commit 426e7bc into bitcoin:master Sep 7, 2016
maflcko pushed a commit that referenced this pull request Sep 7, 2016
Merge #8673: Trivial: Fix obvious assignment/equality error in test
ec139a5 
426e7bc Fix obvious assignment/equality error in test (Jeremy Rubin)
@luke-jr
Copy link
Member

luke-jr commented Sep 10, 2016

Is there any trick to make things like this case fail to compile?

@maflcko maflcko mentioned this pull request Sep 11, 2016
Closed
@JeremyRubin
Copy link
Contributor Author

JeremyRubin commented Sep 13, 2016

@luke-jr I think -Wparentheses?

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
@JeremyRubin @luke-jr
Fix obvious assignment/equality error in test
03b0196 
Github-Pull: bitcoin#8673
Rebased-From: 426e7bc
codablock pushed a commit to codablock/dash that referenced this pull request Jan 9, 2018
@codablock
Merge bitcoin#8673: Trivial: Fix obvious assignment/equality error in…
13a5c83 
… test

426e7bc Fix obvious assignment/equality error in test (Jeremy Rubin)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 9, 2018
@codablock
Merge bitcoin#8673: Trivial: Fix obvious assignment/equality error in…
3d26438 
… test

426e7bc Fix obvious assignment/equality error in test (Jeremy Rubin)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Nov 11, 2018
@JeremyRubin
Fix obvious assignment/equality error in test
a638b37 
Github-Pull: bitcoin#8673
Rebased-From: 426e7bc
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@andvgal
Merge bitcoin#8673: Trivial: Fix obvious assignment/equality error in…
fd4e72d 
… test

426e7bc Fix obvious assignment/equality error in test (Jeremy Rubin)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JeremyRubin @sipa @fanquake @dcousens @paveljanik @maflcko @luke-jr