Fix SIGHASH_SINGLE bug in test_framework SignatureHash #8667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0
Member
|
Any unit tests in which this is exposed? |
Contributor
Author
Member
|
utACK |
Member
|
Shouldn't this affect passing/non-passing of the test? Or is this part of the framework unused? |
Member
Contributor
|
utACK |
Member
|
utACK 2f2548d |
maflcko
pushed a commit
that referenced
this pull request
Sep 9, 2016
2f2548d Fix SIGHASH_SINGLE bug in test_framework SignatureHash (Johnson Lau)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0 Github-Pull: bitcoin#8667 Rebased-From: 2f2548d
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 9, 2018
…eHash 2f2548d Fix SIGHASH_SINGLE bug in test_framework SignatureHash (Johnson Lau)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 9, 2018
…eHash 2f2548d Fix SIGHASH_SINGLE bug in test_framework SignatureHash (Johnson Lau)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…eHash 2f2548d Fix SIGHASH_SINGLE bug in test_framework SignatureHash (Johnson Lau)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0