Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Aug 27, 2016

It is slow, overkill, and does not have a good record of actually catching many problems.

@jonasschnelli
Copy link
Contributor

ACK!

@maflcko
Copy link
Member

maflcko commented Aug 27, 2016

Tested ACK 203f212 (This is the value in my bitcoin.conf)

@sipa
Copy link
Member Author

sipa commented Aug 27, 2016

I guess this obsoletes #8138.

@luke-jr
Copy link
Member

luke-jr commented Aug 27, 2016

Any reason not to bump checklevel up to 4 at the same time?

@fanquake
Copy link
Member

utACK 203f212

@sipa
Copy link
Member Author

sipa commented Aug 28, 2016

@luke-jr Do you have any evidence that that increases the chance for detecting corruption?

@dcousens
Copy link
Contributor

utACK 203f212

@gmaxwell
Copy link
Contributor

ACK

@paveljanik
Copy link
Contributor

utACK 203f212

@laanwj laanwj merged commit 203f212 into bitcoin:master Aug 30, 2016
laanwj added a commit that referenced this pull request Aug 30, 2016
203f212 Reduce default number of blocks to check at startup (Pieter Wuille)
laanwj pushed a commit that referenced this pull request Sep 9, 2016
@maflcko
Copy link
Member

maflcko commented Sep 9, 2016

(Backported in a9429ca)

codablock pushed a commit to codablock/dash that referenced this pull request Jan 9, 2018
203f212 Reduce default number of blocks to check at startup (Pieter Wuille)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 9, 2018
203f212 Reduce default number of blocks to check at startup (Pieter Wuille)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Oct 23, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
203f212 Reduce default number of blocks to check at startup (Pieter Wuille)
furszy added a commit to PIVX-Project/PIVX that referenced this pull request Jun 28, 2021
73d7288 [Doc] Mention reindex-chainstate in the release notes (random-zebra)
c45c0ec Skip MoneySupply update during reindex/reindex-chainstate (random-zebra)
efe193f Scan for better chains in ThreadImport (random-zebra)
0aceea3 Make ProcessNewBlock dbp const and update comment (Pieter Wuille)
8255e82 [Cleanup] Remove fVerifyingBlocks global flag (random-zebra)
30c7aed Add -reindex-chainstate that does not rebuild block index (random-zebra)
79d5cb2 Verify DB with original default check-level 3 (random-zebra)
ed96859 Reduce default number of blocks to check at startup (Pieter Wuille)
d4516fa Log/report in 10% steps during VerifyDB (Jonas Schnelli)
cce2c9e doc: Mention dbcache increase in release notes (random-zebra)
11dc022 [GUI] Update default db cache size in the options model (random-zebra)
9b7f764 Bump `-dbcache` default to 300MiB (Wladimir J. van der Laan)

Pull request description:

  This was attempted already in #1864 and #1907.
  Third time's a charm.

  Now the speed is acceptable and (unlike what was happening in #1907) the process can be interrupted.
  Further, as it is performed in ThreadImport, the GUI is open and functional during the chainstate reindex, instead of being seemingly stuck at the splash screen.

  This PR also includes a few improvements coming from bitcoin#10919, bitcoin#8273, bitcoin#8136 and bitcoin#8611.

  Here's a quick comparison of the data I had testing here (empty wallet with GUI, empty pivx.conf / default values).
  The reindexes have been performed with 0 network connections.

  <table>
  <tr>
  <th>Mainnet (height=2847011)</th><th>Master</th><th>this PR</th>
  </tr><tr>
  <td>online sync</td><td>8 hr 13 min</td><td>6 hr 42 min</td>
  </tr><tr>
  <td>-reindex (offline)</td><td>7 hr 14 min</td><td>6 hr 21 min</td>
  </tr><tr>
  <td>-reindex-chainstate (offline)</td><td>N/A</td><td>6 hr 13 min</td>
  </tr><tr>
  <td>startup (synced node)</td><td>100 sec</td><td>83 sec</td>
  </tr><tr>
  <td>RAM (synced node)</td><td>1.65 GiB</td><td>1.5 GiB</td>
  </tr><tr>
  <td>utxo_cache (synced node)</td><td>28.9MiB</td><td>39.5MiB</td>
  </tr>
  </table>

ACKs for top commit:
  furszy:
    re-ACK 73d7288, tested again.

Tree-SHA512: fb828d89692ccb6105eae5411b70a3c7a129d98d3101121cf604171de1b818a8c68b3771cc69fcf0a04642fe1327ee7ce360a72ecd7ef019b1614bd83c081de5
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants