Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Aug 26, 2016

Build:

  • LevelDB platform was not guessed correctly (it ended up defining -DOS_OPENBSD59 instead of -DOS_OPENBSD). This has been fixed by adding explicit checks for OpenBSD and FreeBSD.
  • On OpenBSD there is no convenience link from python3.5 to python3: add detection for other python interpreter names.
  • If it has to guess the LevelDB OS, print a autoconf warning so that the user can check.

Changes to build-openbsd.md:

  • Python 3 now supported.
  • Bump boost version to 1.61 - one boost patch no longer needed.
  • All checked with OpenBSD 5.9, except for the clang part, I left this as-is for someone adventurous.
  • Mention overriding resource limits, OpenBSD's default ulimit does not suffice for building Bitcoin Core with gcc 4.9.3.

@laanwj
Copy link
Member Author

laanwj commented Aug 26, 2016

@theuni can you take a look at the build system changes?

@paveljanik
Copy link
Contributor

utACK b96fd9b

laanwj added 2 commits August 28, 2016 16:12
- LevelDB platform was not guessed correctly (it ended up defining
  `-DOS_OPENBSD59` instead of `-DOS_OPENBSD`)

- On OpenBSD there is no convenience link from `python3.5` to `python3`:
  add detection for other python interpreter names.

- If it has to guess the LevelDB OS, print a autoconf warning so that
  the user can check.
- Python 3 now supported.

- Bump boost version to 1.61 - one boost patch no longer needed.

- All checked with OpenBSD 5.9, except for the clang part, I left this
  as-is for someone adventurous.

- Mention overriding resource limits, OpenBSD's default ulimit does not
  suffice for building Bitcoin Core with gcc 4.9.3.
@laanwj laanwj force-pushed the 2016_08_openbsd_update branch from b96fd9b to 6275123 Compare August 28, 2016 14:12
@fanquake
Copy link
Member

Tested ACK compiled 0.13.0 + 6275123 on OpenBSD5.9

Built with VirtualBox 5.1.4 on OS X 10.11 . Didn't check the Clang part.

Needed the autogen.sh changes otherwise I saw the same issues as #8127, so that should be closed when this is merged.

@theuni
Copy link
Member

theuni commented Aug 31, 2016

utACK 6275123. Looks good to me.

@laanwj laanwj merged commit 6275123 into bitcoin:master Aug 31, 2016
laanwj added a commit that referenced this pull request Aug 31, 2016
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
@sipa sipa mentioned this pull request Sep 7, 2016
codablock pushed a commit to codablock/dash that referenced this pull request Jan 9, 2018
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 9, 2018
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
zkbot added a commit to zcash/zcash that referenced this pull request Jan 25, 2021
Prepare for LevelDB 1.22 update

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7944
- bitcoin/bitcoin#8604
  - Only the first commit (we removed the upstream build documentation).
- bitcoin/bitcoin#12294
  - Only the third commit.
- bitcoin/bitcoin#13659
- bitcoin/bitcoin#16110
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants