[qa] abandonconflict: Use assert_equal #8531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK, good idea |
laanwj
added a commit
that referenced
this pull request
Aug 18, 2016
fa64306 [qa] abandonconflict: Use assert_equal (MarcoFalke)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8531 Rebased-From: fa64306
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
fa64306 [qa] abandonconflict: Use assert_equal (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be quite a few assertions failing lately. A lot of them which assert balances: https://travis-ci.org/bitcoin/bitcoin/jobs/152925845
This changes
assert()toassert_equal(), so it is easier to see what the value was that caused it to fail.