-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Update p2p-segwit.py to reflect correct behavior #8528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qa/rpc-tests/p2p-segwit.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this code could be commented better I think. I did intend for the transaction to be too large for standardness rules, to ensure that we were checking for premature witness before doing the IsStandard check (that change was a recent bugfix). Perhaps just improve the comment, rather than change the test itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly clear what you were shooting for, so feel free to suggest new text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of this:
# We'll add an unnecessary witness to this transaction that would cause
# it to be non-standard, to test that violating policy with a witness before
# segwit activation doesn't blind a node to a transaction. Transactions
# rejected for having a witness before segwit activation shouldn't be added
# to the rejection cache.
And then at line 312, add a comment:
# Note that this should be rejected for the premature witness reason,
# rather than a policy check, since segwit hasn't activated yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, pushed
|
utACK |
|
utACK 5547aeb |
1 similar comment
|
utACK 5547aeb |
Github-Pull: bitcoin#8528 Rebased-From: bc1d1f2
Github-Pull: bitcoin#8528 Rebased-From: 5547aeb
|
This is backported in #8772, removing needs-backport tag. |
Uh oh!
There was an error while loading. Please reload this page.