Skip to content

Trivial: Corrected JSON typo on setban of net.cpp #8512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Aug 17, 2016
Merged

Trivial: Corrected JSON typo on setban of net.cpp #8512

laanwj merged 1 commit into from
Aug 17, 2016

Conversation

@sevastos
Copy link
Contributor

@sevastos sevastos commented Aug 14, 2016

It was returning

Examples:
> bitcoin-cli setban "192.168.0.6" "add" 86400
> bitcoin-cli setban "192.168.0.0/24" "add"
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "setban", "params": ["192.168.0.6", "add" 86400] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

(Missing the comma on the RPC example)

@maflcko maflcko added the Docs label Aug 14, 2016
@jonasschnelli
Copy link
Contributor

jonasschnelli commented Aug 15, 2016

ACK 6ffd996

1 similar comment
@paveljanik
Copy link
Contributor

paveljanik commented Aug 15, 2016

ACK 6ffd996

@laanwj laanwj merged commit 6ffd996 into bitcoin:master Aug 17, 2016
laanwj added a commit that referenced this pull request Aug 17, 2016
@laanwj
Merge #8512: Trivial: Corrected JSON typo on setban of net.cpp
29496fc 
6ffd996 Corrected JSON typo on setban of net.cpp (Sev)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
@sevastos @luke-jr
Corrected JSON typo on setban of net.cpp
156e305 
Github-Pull: bitcoin#8512
Rebased-From: 6ffd996
codablock pushed a commit to codablock/dash that referenced this pull request Jan 8, 2018
@laanwj @codablock
Merge bitcoin#8512: Trivial: Corrected JSON typo on setban of net.cpp
5c928f0 
6ffd996 Corrected JSON typo on setban of net.cpp (Sev)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Oct 25, 2018
@sevastos
Corrected JSON typo on setban of net.cpp
e1f964b 
Github-Pull: bitcoin#8512
Rebased-From: 6ffd996
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#8512: Trivial: Corrected JSON typo on setban of net.cpp
67c8909 
6ffd996 Corrected JSON typo on setban of net.cpp (Sev)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sevastos @jonasschnelli @paveljanik @laanwj @maflcko