document return value of networkhashps for getmininginfo RPC endpoint #8461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK 205eb35 As you are touching the helptext, can you please align "errors" and "chain" helptexts by adding two spaces before "(string)"? |
Contributor
|
ACK 205eb35 agree with @paveljanik about the PR related nits. |
Member
|
ACK 65f4532 |
Contributor
Author
|
Updated to align "chain" and "errors" output with rest of help text. |
Contributor
|
Thank you! ACK 65f4532 |
Contributor
|
ACK 65f4532 |
1 similar comment
Member
|
ACK 65f4532 |
laanwj
added a commit
that referenced
this pull request
Aug 19, 2016
… RPC endpoint 65f4532 document return value of networkhashps for getmininginfo RPC endpoint (Jameson Lopp)
Member
|
Backport needed, I guess. (all the way back to 0.9.x, but we don't maintain that far back) |
Member
|
@luke-jr According to current https://bitcoincore.org/en/lifecycle/ 0.11 only receives critical security fixes and this is only a documentation fix. (Though, I am not against backports for 0.12 and 0.13) |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8461 Rebased-From: 65f4532
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
…inginfo RPC endpoint 65f4532 document return value of networkhashps for getmininginfo RPC endpoint (Jameson Lopp)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…inginfo RPC endpoint 65f4532 document return value of networkhashps for getmininginfo RPC endpoint (Jameson Lopp)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this value isn't documented in the RPC help. If it would be helpful, we could be even more specific and mention that it uses the default trailing 120 blocks parameter to calculate the hashrate.