[Wallet] Trivial cleanup of HD wallet changes #8443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think you can use func because the wallet seems a place where a lot Anyway, concept ACK |
src/wallet/wallet.cpp
Outdated
Contributor
There was a problem hiding this comment.
AddKeyPubKey failed, not AddKey. And it can't "fail" at all right now 8)
Member
There was a problem hiding this comment.
The goal was to keep this in case some refactoring makes it possible that it fails.
jonasschnelli
force-pushed
the
2016/08/hd_fixes
branch
from
e3e706f to
a81e77e
Compare
Contributor
Author
|
Fixed nits. |
src/wallet/wallet.cpp
Outdated
jonasschnelli
force-pushed
the
2016/08/hd_fixes
branch
from
a81e77e to
a575426
Compare
Contributor
Author
|
Fixed @paveljanik's nit. |
Contributor
|
ACK a575426 |
Member
|
utACK a575426 |
Member
|
@laanwj Anything holding this back? |
src/wallet/wallet.cpp
Outdated
Member
There was a problem hiding this comment.
You shouldn't prefix CWallet:: here
Contributor
Author
There was a problem hiding this comment.
Removed the prefix.
jonasschnelli
force-pushed
the
2016/08/hd_fixes
branch
from
a575426 to
7e5d94d
Compare
Member
|
utACK 7e5d94d |
jonasschnelli
added a commit
that referenced
this pull request
Aug 19, 2016
7e5d94d [Wallet] Trivial cleanup of HD wallet changes (Jonas Schnelli)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8443 Rebased-From: 7e5d94d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial cleanup.
Reported by @MarcoFalke and @dooglus.