Skip to content

Conversation

@Christewart
Copy link
Contributor

Improves clarity for README in the test directory

@sipa
Copy link
Member

sipa commented Jul 29, 2016

Can you stick to the text width of 80 characters, and provide a more accurate commit message? Also, it's not improving clarify - the original text in README.md right now is simply wrong and this PR fixes it.

@Christewart Christewart changed the title Update README.md Update README.md inside of src/test/ Jul 30, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an example

@paveljanik
Copy link
Contributor

Please squash all commits after fixing nits.

Updating documentation for adding new unit test files

Removing unneeded sentence from README

Removing uint160_tests.cpp as it DNE

Formatting command line instructions to use ``

fixing 80 char formatting issue in README

fixing more nits
@Christewart Christewart force-pushed the imporve_test_readme branch from 242d886 to b8db185 Compare July 31, 2016 17:44
@Christewart
Copy link
Contributor Author

For some reason I couldn't squash to a more descriptive commit message, I tried following bitcoin core's guide and got an error saying I couldn't pick the specific commit I wanted to show

@maflcko
Copy link
Member

maflcko commented Jul 31, 2016

try git commit --amend

@laanwj laanwj merged commit b8db185 into bitcoin:master Aug 3, 2016
laanwj added a commit that referenced this pull request Aug 3, 2016
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
Updating documentation for adding new unit test files

Removing unneeded sentence from README

Removing uint160_tests.cpp as it DNE

Formatting command line instructions to use ``

fixing 80 char formatting issue in README

fixing more nits

Github-Pull: bitcoin#8428
Rebased-From: b8db185
codablock pushed a commit to codablock/dash that referenced this pull request Jan 8, 2018
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Nov 11, 2018
Updating documentation for adding new unit test files

Removing unneeded sentence from README

Removing uint160_tests.cpp as it DNE

Formatting command line instructions to use ``

fixing 80 char formatting issue in README

fixing more nits

Github-Pull: bitcoin#8428
Rebased-From: b8db185
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants