net: Ignore notfound P2P messages
#8427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 5c9e49d |
Contributor
|
utACK 5c9e49d |
Contributor
|
utACK 5c9e49d |
Member
|
utACK 5c9e49d |
sipa
added a commit
that referenced
this pull request
Jul 30, 2016
5c9e49d net: Ignore `notfound` P2P messages (Wladimir J. van der Laan)
Contributor
|
all this influence I have on bitcoin yet never make it into the commit logs! |
Contributor
|
Ok, I have to ask this. Why are these messages generated if they are ignored? |
Member
Author
If you had changed your PR after @sipa and my suggestion I'd just have merged that one. I didn't want to have this linger for weeks.
That's a good question. From what I remember, some SPV clients pay attention to the message. Maybe you can find the PR introducing the message in history. |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8427 Rebased-From: 5c9e49d
This was referenced Oct 21, 2016
zkbot
pushed a commit
to zcash/zcash
that referenced
this pull request
Oct 22, 2016
…ion, r=daira Upstream: Only send one GetAddr response per connection. bitcoin/bitcoin#8427
zkbot
pushed a commit
to zcash/zcash
that referenced
this pull request
Oct 22, 2016
Upstream: Prevent possible DoS in logging bitcoin/bitcoin#8427
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
5c9e49d net: Ignore `notfound` P2P messages (Wladimir J. van der Laan)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 24, 2018
Github-Pull: bitcoin#8427 Rebased-From: 5c9e49d
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
5c9e49d net: Ignore `notfound` P2P messages (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid logging
notfoundmessages as unknown "command".Alternative to #8403.