Enable size accounting in mining unit tests #8419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 8bfd708 |
Contributor
|
utACK 8bfd708 |
1 similar comment
Contributor
|
utACK 8bfd708 |
| // Disable size accounting (CPFP does not support it) | ||
| mapArgs["-blockmaxsize"] = strprintf("%u", MAX_BLOCK_SERIALIZED_SIZE); | ||
|
|
||
| // Note that by default, these tests run with size accounting enabled. |
Member
There was a problem hiding this comment.
Whoa, this global state was set without reverting it again at the end of the testcase? Please don't do that.
In any case ACK.
laanwj
added a commit
that referenced
this pull request
Aug 1, 2016
8bfd708 Enable size accounting in mining unit tests (Suhas Daftuar)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8419 Rebased-From: 8bfd708
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the unit test should have happened in #8295. Now that size accounting is supported by the mining algorithm, we shouldn't disable size accounting in the mining unit tests.