Skip to content

Conversation

@jonasschnelli
Copy link
Contributor

No description provided.

@jonasschnelli
Copy link
Contributor Author

Fixes #8410

@maflcko
Copy link
Member

maflcko commented Jul 28, 2016

Thanks for adding helpful comments!

Looks good utACK 54af51d

On Thu, Jul 28, 2016 at 3:07 PM, Jonas Schnelli [email protected]
wrote:

Fixes #8410 #8410


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8417 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGGmv4IYRv6WKzvpt7bGCNrIuD9M8rNoks5qaKmtgaJpZM4JXMQj
.

@laanwj
Copy link
Member

laanwj commented Jul 29, 2016

Thanks, a test for this is very welcome, test code looks good to me
utACK 54af51d

@laanwj laanwj merged commit 54af51d into bitcoin:master Jul 29, 2016
laanwj added a commit that referenced this pull request Jul 29, 2016
…-tests)

54af51d [QA] Add walletdump RPC test (including HD- & encryption-tests) (Jonas Schnelli)
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import *
import os
import shutil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import

@maflcko
Copy link
Member

maflcko commented Aug 1, 2016

Sorry for the delayed feedback. I will try to create another pull to address those.

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016
codablock pushed a commit to codablock/dash that referenced this pull request Feb 1, 2018
…ryption-tests)

54af51d [QA] Add walletdump RPC test (including HD- & encryption-tests) (Jonas Schnelli)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
…ryption-tests)

54af51d [QA] Add walletdump RPC test (including HD- & encryption-tests) (Jonas Schnelli)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
…ryption-tests)

54af51d [QA] Add walletdump RPC test (including HD- & encryption-tests) (Jonas Schnelli)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants