Process "notfound" messages, and safeguard against unreasonably long … #8403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| boost::this_thread::interruption_point(); | ||
| if (inv.type == MSG_TX || inv.type == MSG_WITNESS_TX) | ||
| LogPrint("tx", "notfound: %s from peer=%d\n", inv.ToString(), pfrom->id); |
Member
There was a problem hiding this comment.
Do you really want to log a line for every single record? This can be up to 50,000 in one message.
Member
|
Concept ACK, though I think the number of log lines per message should be limited. |
Contributor
|
Do we need to log any details here at all? We've done fine for years without doing so... |
Member
|
I think we can just 'process' notfound messages by ignoring them.
|
Member
|
Agree @sipa. If you really, really want to log them (say, for debugging purposes) they should be in a separate log class, and the entire processing should be skipped if this log class is not enabled. |
Member
|
Closing in favor of #8427. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ones.
For years, I've been getting many many of these in my debug.log:-
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
2016-07-25 15:10:45 Unknown command "notfound" from peer=62719
This pull request will remove this message, which is technically incorrect anyway.