Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Jul 18, 2016

@laanwj laanwj added the Mining label Jul 18, 2016
@laanwj laanwj added this to the 0.13.0 milestone Jul 18, 2016
@laanwj laanwj force-pushed the 2016_07_block_weight branch from 4ce7030 to bf70224 Compare July 18, 2016 06:25
@maflcko
Copy link
Member

maflcko commented Jul 18, 2016

ACK bf70224 (Haven't checked for proper replacement in all places but I imagine check-doc would catch that.)

@paveljanik
Copy link
Contributor

paveljanik commented Jul 18, 2016

src/rpc/blockchain.cpp: " "cost" : n (numeric) The block cost\n"
src/rpc/mining.cpp: " "currentblockcost": nnn, (numeric) The last block cost\n"
src/main.cpp: return state.DoS(100, error("ContextualCheckBlock(): cost limit failed"), REJECT_INVALID, "bad-blk-cost");

etc.

@paveljanik
Copy link
Contributor

Hmm, what about using the term "blockcost" instead?

@laanwj
Copy link
Member Author

laanwj commented Jul 18, 2016

@paveljanik yes if you want to change all occurrences, also in variable names, then there is much more code impact.

@laanwj
Copy link
Member Author

laanwj commented Jul 18, 2016

Bah, changing all occurences of 'cost' to 'weight' is a huge change.
I'm also having second thoughts about it.
Changing it just in user-facing messages is doable, but yes it also appears in the RPC API, in variable names, in tons of comments. And I suppose those all have to be changed for consistency.

@laanwj laanwj closed this Jul 18, 2016
laanwj added a commit to laanwj/bitcoin that referenced this pull request Jul 18, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants