Skip to content

[qa] wallet*.py: Check for salvagewallet regressions #8319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maflcko wants to merge 1 commit into from
Closed

[qa] wallet*.py: Check for salvagewallet regressions #8319

maflcko wants to merge 1 commit into from

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 8, 2016 •
edited
Loading

This checks for the bug reported in #2480 and #8300.

@maflcko maflcko mentioned this pull request Jul 9, 2016
Merged
@paveljanik
Copy link
Contributor

paveljanik commented Jul 12, 2016

wallet.py fails tests.

@maflcko maflcko changed the title [qa] wallet*.py: Check for salvagewallet regressions [WIP] [qa] wallet*.py: Check for salvagewallet regressions Jul 12, 2016
@laanwj
Copy link
Member

laanwj commented Jul 14, 2016 •
edited
Loading

Re-triggered travis after merging #8324
Ok, passes locally, and in travis as well. WIP tag can go?

@maflcko maflcko changed the title [WIP] [qa] wallet*.py: Check for salvagewallet regressions [qa] wallet*.py: Check for salvagewallet regressions Jul 14, 2016
@laanwj laanwj added this to the 0.13.0 milestone Jul 14, 2016
laanwj
laanwj reviewed Jul 15, 2016
View reviewed changes
qa/rpc-tests/wallet.py Outdated
Copy link
Member

@laanwj laanwj Jul 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this conflicts with the above comment

Copy link
Member Author

@maflcko maflcko Jul 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on purpose. Not sure how to proceed.

@maflcko
Copy link
Member Author

maflcko commented Jul 15, 2016

Don't consider this pull a blocker for rc1. It should test the regression well enough for now but there might be things to improve and work on later. You can merge it now or leave it for later. I shouldn't matter too much, maybe flip a coin?

@laanwj
Copy link
Member

laanwj commented Jul 18, 2016

Right - going to remove this from the milestone, I don't think we should re-enable a -salvagewallet test as long as we have #7463.

@laanwj laanwj removed this from the 0.13.0 milestone Jul 18, 2016
@sipa
Copy link
Member

sipa commented Apr 9, 2017

What is blocking this? It seems #7463 is still open.

@maflcko
Copy link
Member Author

maflcko commented Apr 16, 2017

Yes, I think this is still relevant. I will put it on my list for 0.15. It seems that I need to catch up with the recent hdwallet changes first. Closing for now.

@maflcko maflcko closed this Apr 16, 2017
@maflcko maflcko added this to the 0.15.0 milestone Apr 16, 2017
@maflcko maflcko deleted the Mf1607-qaSalv branch April 29, 2018 22:37
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests Wallet

Projects

None yet

Milestone

0.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@maflcko @paveljanik @laanwj @sipa