Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 5, 2016

@theuni @jonasschnelli Not sure on this one but the core sever can use whitelisting to avoid DOS and "other things".

@luke-jr
Copy link
Member

luke-jr commented Jul 5, 2016

Wherever it is, please ensure all the Travis IPs get whitelisted. They're currently not, so Mac builds are failing for at least Knots.

@maflcko
Copy link
Member Author

maflcko commented Jul 5, 2016

Mac builds are failing for at least Knots.

I am wondering if this was fixed for 0.13 by #8067.

@luke-jr
Copy link
Member

luke-jr commented Jul 5, 2016

I don't see why it would be?

@maflcko
Copy link
Member Author

maflcko commented Jul 5, 2016

I don't see why it never happened in the bitcoin core repo, or did I just miss it? As #8067 and previous pulls removed the special flags for the bitcoin repo, it should happen for us as well...

@luke-jr
Copy link
Member

luke-jr commented Jul 5, 2016

Not sure, maybe Travis reuses the same servers for repositories.

@jonasschnelli
Copy link
Contributor

Travis seems happy now. I guess @theuni did update the whitelist.
Does travis use different outbound IPs?

I'll try now to re-trigger travis a couple of times to make sure it will work on different travis instances.

@luke-jr
Copy link
Member

luke-jr commented Jul 6, 2016

It seems to be reliably failing for the bitcoinknots/bitcoin repo at least as of a week ago. I just started a retry here: https://travis-ci.org/bitcoinknots/bitcoin/builds/142818285

For reference, the full IP range is supposedly at: https://docs.travis-ci.com/user/ip-addresses/

@theuni
Copy link
Member

theuni commented Jul 6, 2016

I'm investigating this now. The ranges should be enabled, but I'm seeing failures that I can't pinpoint.

@theuni
Copy link
Member

theuni commented Jul 6, 2016

I believe I've tracked this down to a local server config issue. IPs weren't always presented correctly (hooray, Cloudflare!), so the filtering didn't work as expected. It should be pretty clear after a few travis builds if all is in order now.

@theuni
Copy link
Member

theuni commented Jul 7, 2016

ACK. This should be good to go now.

@jonasschnelli jonasschnelli merged commit fa6ad56 into bitcoin:master Jul 7, 2016
jonasschnelli added a commit that referenced this pull request Jul 7, 2016
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
@maflcko maflcko deleted the Mf1606-travisSDKURL branch July 7, 2016 18:52
codablock pushed a commit to codablock/dash that referenced this pull request Dec 28, 2017
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants