-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[travis] Update SDK_URL #8304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[travis] Update SDK_URL #8304
Conversation
|
Wherever it is, please ensure all the Travis IPs get whitelisted. They're currently not, so Mac builds are failing for at least Knots. |
I am wondering if this was fixed for 0.13 by #8067. |
|
I don't see why it would be? |
|
I don't see why it never happened in the bitcoin core repo, or did I just miss it? As #8067 and previous pulls removed the special flags for the bitcoin repo, it should happen for us as well... |
|
Not sure, maybe Travis reuses the same servers for repositories. |
|
Travis seems happy now. I guess @theuni did update the whitelist. I'll try now to re-trigger travis a couple of times to make sure it will work on different travis instances. |
|
It seems to be reliably failing for the bitcoinknots/bitcoin repo at least as of a week ago. I just started a retry here: https://travis-ci.org/bitcoinknots/bitcoin/builds/142818285 For reference, the full IP range is supposedly at: https://docs.travis-ci.com/user/ip-addresses/ |
|
I'm investigating this now. The ranges should be enabled, but I'm seeing failures that I can't pinpoint. |
|
I believe I've tracked this down to a local server config issue. IPs weren't always presented correctly (hooray, Cloudflare!), so the filtering didn't work as expected. It should be pretty clear after a few travis builds if all is in order now. |
|
ACK. This should be good to go now. |
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
@theuni @jonasschnelli Not sure on this one but the core sever can use whitelisting to avoid DOS and "other things".