qt: Network-specific example address #8288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate an (invalid) example address for in the bitcoin address widgets, based on the network prefix, instead of hardcoding a mainnet address. - `1NS17iag9jJgTHD1VXjvLCEnZuQ3rJDE9L` for mainnet (same as now) - `n2wxQmfexkjwEPgdD6iJA7T7RtzkmHxhFc` for testnet
laanwj
force-pushed
the
2016_06_network_based_example_address
branch
from
5e3baf4 to
4f44cb6
Compare
Member
|
utACK 4f44cb6 |
Contributor
|
ACK 4f44cb6 |
Contributor
|
Yes. Why not. utACK 4f44cb6 |
Member
|
ACK 4f44cb6 Mainnet |
| #endif | ||
| } | ||
|
|
||
| // Just some dummy data to generate an convincing random-looking (but consistent) address |
jonasschnelli
added a commit
that referenced
this pull request
Jul 6, 2016
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate an example address (with invalid CRC) for in the bitcoin address widgets, based on the network prefix, instead of hardcoding a mainnet address.
Generates:
1NS17iag9jJgTHD1VXjvLCEnZuQ3rJDE9Lfor mainnet (same as now)n2wxQmfexkjwEPgdD6iJA7T7RtzkmHxhFcfor testnetLater on we may get rid of the example address completely, but that's too late for 0.13, as removing
e.g. %1would change a translation string.