Updating default max block size #8268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing artificial limit in max block size from 750KB to 1MB.
Contributor
Contributor
|
It is good practice to always first check for possible duplicates. |
Author
|
@jonasschnelli I did not realize this was a duplicate. Thanks for the references to the former commits @paveljanik As a comment though, is not the blocksize 1MB? Why then are we artificially making it lower? This commit I have submitted along with others is not changing the blocksize nor forking anything, tis only correcting the default settings to be match with the rules of the protocol (of 1MB blocksize). |
Contributor
|
@Cannon-Ciota Please read both duplicates. There are enough arguments against this change at this time already. if you have new argument, please bring it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing artificial limit in max block size from 750KB to 1MB.