RPC: Hide softfork if timeout is 0 #8258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK 409f833 Without this change, the current master shows (RPC |
Member
|
ACK
|
Contributor
|
ACK 409f833 |
laanwj
added a commit
that referenced
this pull request
Jun 27, 2016
409f833 RPC: Hide softfork if timeout is 0 (jl2012)
Member
|
This needs backport to 0.12, but will only merge cleanly after segwit. |
Contributor
Author
|
@laanwj I don't think a backport is needed since we won't release a backport with undefined softfork |
Member
|
OK |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
409f833 RPC: Hide softfork if timeout is 0 (jl2012)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
409f833 RPC: Hide softfork if timeout is 0 (jl2012)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #8209
getblockchaininfo will not show a BIP9 proposal if the timeout is 0. A timeout before the genesis block timestamp guarantees that a softfork must not be activated in any circumstances. A timeout of 0 should be used when we want to merge a softfork proposal without defining its deployment schedule