BUG: bitcoin-qt crash #8256
Merged
BUG: bitcoin-qt crash #8256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch! |
Member
|
Concept ACK. Thanks for adding steps to reproduce! |
src/qt/transactionview.cpp
Outdated
Member
There was a problem hiding this comment.
nit: you could move this down two lines and do:
if (selection.empty())
return;
Contributor
|
Thanks. Seems necessary. |
laanwj
added a commit
that referenced
this pull request
Jun 24, 2016
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Dec 20, 2017
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Dec 21, 2017
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
sidhujag
added a commit
to syscoin/syscoin
that referenced
this pull request
Jan 2, 2018
But fix properly, bitcoin upstream did not fix properly
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jan 5, 2018
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
NarubyRiverlione
added a commit
to NarubyRiverlione/spice
that referenced
this pull request
Feb 4, 2018
* 'spice' of github.com:NarubyRiverlione/spice: (8382 commits) updated testnet genessis spice images more rename genesis blocks ports magic message letters start letter addresses cleanup : * remove gitian signatures * remove seeds rename: more originale files rename Prepare 0.12.2.3 release notes (dashpay#1846) Avoid reference leakage in CKeyHolderStorage::AddKey (dashpay#1840) Protect CKeyHolderStorage via mutex (dashpay#1834) Skip existing masternode conections on mixing (dashpay#1833) Merge pull request dashpay#1836 from lodgepole/feature/backport-11847 Fix -liquidityprovider option (dashpay#1829) Vote on IS only if it was accepted to mempool (dashpay#1826) bump version to 0.12.2.3 (dashpay#1827) Merge bitcoin#8256: BUG: bitcoin-qt crash Swap iterations and fUseInstantSend parameters in ApproximateBestSubset (dashpay#1819) Fix crash on exit when -createwalletbackups=0 (dashpay#1810) Prepare v0.12.2.2 release notes (dashpay#1769) Force rcc to use resource format version 1. (dashpay#1784) ... # Conflicts: # contrib/gitian-descriptors/gitian-osx-signer.yml # contrib/gitian-descriptors/gitian-win-signer.yml # src/chainparams.cpp # src/qt/res/icons/bitcoin.icns # src/qt/res/icons/bitcoin.ico # src/qt/res/icons/bitcoin.png # src/qt/res/icons/crownium/about.png # src/qt/res/icons/drkblue/about.png # src/qt/res/icons/drkblue/bitcoin.png # src/qt/res/icons/light/about.png # src/qt/res/icons/light/remove.png # src/qt/res/icons/remove.png # src/qt/res/icons/trad/about.png # src/qt/res/icons/trad/remove.png
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce bug:
I found that error at the line:
hash.SetHex(selection.at(0).data(TransactionTableModel::TxHashRole).toString().toStdString());and I added the check.
My system: Linux Mint 18, Qt 5.5