Skip to content

Check if the macro PKG_PROG_PKG_CONFIG was expanded. #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paveljanik wants to merge 1 commit into from
Closed

Check if the macro PKG_PROG_PKG_CONFIG was expanded. #8242

paveljanik wants to merge 1 commit into from

Conversation

@paveljanik
Copy link
Contributor

@paveljanik paveljanik commented Jun 22, 2016 •
edited
Loading

If pkg-config is not installed, pkg-config's pkg.m4 is not installed and thus the macro PKG_PROG_PKG_CONFIG is not expanded.

Fixes #8228.

With this change, the output without pkg-config installed is:

...
configure.ac:83: error: PKG_PROG_PKG_CONFIG macro not expanded, please install pkg-config
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
bitcoin@linux-fx0x:~/bitcoin>

@paveljanik
Check if the macro PKG_PROG_PKG_CONFIG was expanded.
5d79863 
If pkg-config is not installed, pkg-config's pkg.m4 is not installed
and thus the macro PKG_PROG_PKG_CONFIG is not expanded.

Fixes bitcoin#8228.
@fanquake
Copy link
Member

fanquake commented Jun 23, 2016

Tested on OS X with brew unlink pkg-config

./autogen.sh
configure.ac:83: error: PKG_PROG_PKG_CONFIG macro not expanded, please install pkg-config
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/local/Cellar/autoconf/2.69/bin/autoconf failed with exit status: 1

./configure
configure: error: pkg-config not found.

@theuni
Copy link
Member

theuni commented Jun 23, 2016

pkg-config isn't required for win32. The fact that it is in some places atm is a bug.

@luke-jr
Copy link
Member

luke-jr commented Jun 23, 2016

While I generally support making as much as possible optional, I see no value in pkg-config (or pkgconf) being optional.

@theuni
Copy link
Member

theuni commented Jun 23, 2016

@luke-jr reason being that it sometimes does more harm than good on Windows. But I suppose at this point we may be over-complicating things by trying to avoid the dependency.

Maybe we'd be better off requiring it everywhere, and just not using it for Windows.

@paveljanik
Copy link
Contributor Author

paveljanik commented Jun 23, 2016

@theuni I do not like requiring it where we do not need it. If we do not use it, it is more difficult to start compiling the source code (one more tool to install/workaround).

If this change makes pkg-config unavailability an error, good, we can change it afterwards.

@luke-jr
Copy link
Member

luke-jr commented Jun 23, 2016

Or just require and it everywhere, including Windows... only pkgconf problems I'm aware of were fixed years ago.

@paveljanik
Copy link
Contributor Author

paveljanik commented Jun 23, 2016

@luke-jr Yes, this is the status-quo as of now.

@theuni theuni mentioned this pull request Jul 7, 2016
Merged
@paveljanik
Copy link
Contributor Author

paveljanik commented Jul 30, 2016

Closing. Not needed now after #8314.

@paveljanik paveljanik closed this Jul 30, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No error reporting when pkg-config missing in depends build

5 participants

@paveljanik @fanquake @theuni @luke-jr @maflcko