[Qt] Bump to Qt5.6.1 #8210

jonasschnelli · 2016-06-16T18:50:27Z

Based on (#8053) credits to @fanquake.
Includes osx toolchain bump from @theuni (#8184).

jonasschnelli · 2016-06-16T18:52:21Z

If you compile OSX binaries over depends, you now need the MacOSX10.11.tar.gz SDK.

sipa · 2016-06-16T18:53:34Z

What advantages does 5.6.1 have over 5.5.0?

jonasschnelli · 2016-06-16T18:58:36Z

The release notes for Qt5.6 are here: https://blog.qt.io/blog/2016/03/16/qt-5-6-released/

The reason why I'd like to see this go in before 0.13 is the missing HiDPI support for linux and windows in 5.5
(#6472).

I know, most devs don't care about HiDPI, but almost every laptops and screens sold today support HiDPI.

clang: 3.7.1 cctools: 877.8 ld64: 253.9

laanwj · 2016-06-17T08:05:45Z

As I remember there are quite a few upstream issues solved in 5.6.1, from HiDPI to crashes and window manager integration.
We definitely need to upgrade Qt before 0.13.

laanwj · 2016-06-17T08:12:09Z

Why does this need the OSX toolchain bump?

jonasschnelli · 2016-06-17T08:15:53Z

I ran into Qt compile issues (c++11 atomic issues) with MaxOSX10.9 clang compiler. Haven't tracked it down and I think a toolchain bump to 10.11 is necessary for #7770 anyways and does not affect the minimum required platform,

laanwj · 2016-06-17T08:16:40Z

Ah sorry yes I missed the atomic thing. Makes sense.

jonasschnelli · 2016-06-17T09:29:35Z

There are some issues which I could not already solve

Linux

Somehow it links against libdbus-1.so now and will be rejected by symbol-check.py:

qt/bitcoin-qt: NEEDED library libdbus-1.so.3 is not allowed

https://bitcoin.jonasschnelli.ch/pulls/8210/build-linux.log

MinGW

It doesn't find -lqwindows anymore:

checking for static Qt plugins: -lqwindows... no
configure: WARNING: Could not resolve: -lqwindows; bitcoin-qt frontend will not be built

https://bitcoin.jonasschnelli.ch/pulls/8210/build-win.log

OSX

Works!

jonasschnelli · 2016-06-17T14:06:43Z

contrib/devtools/symbol-check.py

 b'libxcb.so.1', # part of X11
 b'libfontconfig.so.1', # font support
 b'libfreetype.so.6', # font parsing
+b'libdbus-1.so.3', # inter process communication (notification system)


@theuni: Is this a problem? I guess Qt links to libdbus dynamic anyways? And we disable the static library (https://github.com/bitcoin/bitcoin/blob/master/depends/packages/dbus.mk#L9).

fanquake · 2016-06-17T15:16:03Z

One TODO you could add here is dropping dbus from the qt build.
Thanks for picking this up and putting it on top of the toolchain bump. Ill test this, and if it's merged for 0.13, I can rebase #8053 and turn it into testing a QT5.7 update, and the potential enhancements surrounding that.

jonasschnelli · 2016-06-17T18:46:38Z

Compiles now on all three gitian platform: https://bitcoin.jonasschnelli.ch/pulls/8210/

The remaining question:
dynamic link against libdbus-1
https://github.com/bitcoin/bitcoin/pull/8210/files#diff-a225cfb1575f5550c4ba2b912127a730R71

jonasschnelli · 2016-06-17T18:49:12Z

Travis fails because of a missing file (MacOSX10.11.sdk.tar.gz) on bitcoincore.org. Must be placed there by @theuni.

laanwj · 2016-06-18T07:20:53Z

Travis fails because of a missing file (MacOSX10.11.sdk.tar.gz) on bitcoincore.org. Must be placed there by @theuni.

Can we temporarily use a different host?

I wouldn't mind using mine, until we find a permenant solution: https://download.visucore.com/bitcoin/MacOSX10.11.sdk.tar.gz

theuni · 2016-06-18T07:54:14Z

I uploaded this before I left, #8184 should show it being found.

theuni · 2016-06-18T08:06:34Z

Looks like we might need to whitelist a new range at bitcoincore.org for the generic build image. The download fails with "access denied". I can fix next week if there's no workaround in place yet. ...stupid SDK restrictions...

theuni · 2016-06-18T08:59:35Z

Iirc there's a --runtime-dbus (or so) introduced in 5.6 or 5.7 that makes the desired behavior explicit. That, combined with deleting the dbus dependency (and even the package itself) should fix the NEEDED problem.

laanwj · 2016-06-23T14:39:23Z

I think this probably introduced a few bugs

If anything the windows gitian executables seem to be working fine.

maflcko · 2016-07-08T16:37:09Z

I think this probably introduced a few bugs

@theuni Did you find any bugs?

theuni · 2016-07-08T17:36:08Z

@MarcoFalke The pkg-config issue was fixed with 0c928cb. I just tested to see if the xcb issue was reintroduced, and it wasn't. So it looks like we're all good here.

maflcko · 2016-07-10T09:43:38Z

Good to hear. Thanks for having a look.

Darwin build fixes Includes fixes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7136 - Only the third commit (to avoid a merge conflict) - bitcoin/bitcoin#7302 - Excluding the first commit, which is unnecessary (we use Boost 1.62) - bitcoin/bitcoin#7487 - bitcoin/bitcoin#7606 - bitcoin/bitcoin#7711 - bitcoin/bitcoin#7165 - bitcoin/bitcoin#8002 - bitcoin/bitcoin#8210 - Only the second commit - bitcoin/bitcoin#9114

2759597 Only pass -lQt5PlatformSupport if >=Qt5.6 (Jonas Schnelli) 59d063d Use runtime linking of QT libdbus, use custom/temp. SDK URL (Jonas Schnelli) 6194d9a Fix bitcoin_qt.m4 and fix-xcb-include-order.patch (Jonas Schnelli) f6eb4e2 [depends] OpenSSL 1.0.1k - update config_opts (fanquake) f25209a depends: bump OSX toolchain (Cory Fields)

e8fabd9 build: prune dbus from depends (fanquake) Pull request description: Since #8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt. ``` qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus -no-dbus ............. Do not build the Qt D-Bus module -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto] -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no] ``` This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](#7993 (comment)) and [here](#8210 (comment)), but was never followed up. dongcarl also bought it up as part of #16150. I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing. ACKs for top commit: laanwj: code review ACK e8fabd9 Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20

e8fabd9 build: prune dbus from depends (fanquake) Pull request description: Since bitcoin#8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt. ``` qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus -no-dbus ............. Do not build the Qt D-Bus module -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto] -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no] ``` This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](bitcoin#7993 (comment)) and [here](bitcoin#8210 (comment)), but was never followed up. dongcarl also bought it up as part of bitcoin#16150. I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing. ACKs for top commit: laanwj: code review ACK e8fabd9 Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20

6fdf5da depends: only use dbus with qt on linux (fanquake) Pull request description: Since #8210 we've been passing `-dbus-runtime` when configuring Qt, however D-Bus isn't used on macOS or Windows. So rather than blanket passing `-dbus-runtime`, only use D-Bus when building for linux, and disable it for Windows and macOS. This also saves some time building qt in depends (for windows or macOS). This gist contains a diff of the symbols in a macOS bitcoin-qt after applying this change: https://gist.github.com/fanquake/317e5c9c7d1b5e37a0c1ce8001af18c4. ACKs for top commit: laanwj: ACK 6fdf5da Tree-SHA512: 7c7df6036f27dae6adb807edf94cd26b4dafa3728976d219a68f7388b6477777b35acebd507320e4469c9f2fcf016b311c82e0b12d50546cb5ab66a1e955e464

6fdf5da depends: only use dbus with qt on linux (fanquake) Pull request description: Since bitcoin#8210 we've been passing `-dbus-runtime` when configuring Qt, however D-Bus isn't used on macOS or Windows. So rather than blanket passing `-dbus-runtime`, only use D-Bus when building for linux, and disable it for Windows and macOS. This also saves some time building qt in depends (for windows or macOS). This gist contains a diff of the symbols in a macOS bitcoin-qt after applying this change: https://gist.github.com/fanquake/317e5c9c7d1b5e37a0c1ce8001af18c4. ACKs for top commit: laanwj: ACK 6fdf5da Tree-SHA512: 7c7df6036f27dae6adb807edf94cd26b4dafa3728976d219a68f7388b6477777b35acebd507320e4469c9f2fcf016b311c82e0b12d50546cb5ab66a1e955e464

Enable macOS cross-compilation Includes code cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7809 - The `native_cctools` fix. - bitcoin/bitcoin#8210 - The macOS toolchain bump. - bitcoin/bitcoin#9891 - bitcoin/bitcoin#15581 - The `tar` change. - bitcoin/bitcoin#16049 - The `native_cctools` change. Build instructions: - Fetch `MacOSX10.11.sdk` from e.g. https://github.com/phracker/MacOSX-SDKs/releases - Extract it into `depends/SDKs` (creating that folder first) - `HOST=x86_64-apple-darwin11 ./zcutil/build.sh`

e8fabd9 build: prune dbus from depends (fanquake) Pull request description: Since #8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt. ``` qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus -no-dbus ............. Do not build the Qt D-Bus module -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto] -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no] ``` This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](bitcoin/bitcoin#7993 (comment)) and [here](bitcoin/bitcoin#8210 (comment)), but was never followed up. dongcarl also bought it up as part of #16150. I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing. ACKs for top commit: laanwj: code review ACK e8fabd9 Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20

6fdf5da depends: only use dbus with qt on linux (fanquake) Pull request description: Since bitcoin#8210 we've been passing `-dbus-runtime` when configuring Qt, however D-Bus isn't used on macOS or Windows. So rather than blanket passing `-dbus-runtime`, only use D-Bus when building for linux, and disable it for Windows and macOS. This also saves some time building qt in depends (for windows or macOS). This gist contains a diff of the symbols in a macOS bitcoin-qt after applying this change: https://gist.github.com/fanquake/317e5c9c7d1b5e37a0c1ce8001af18c4. ACKs for top commit: laanwj: ACK 6fdf5da Tree-SHA512: 7c7df6036f27dae6adb807edf94cd26b4dafa3728976d219a68f7388b6477777b35acebd507320e4469c9f2fcf016b311c82e0b12d50546cb5ab66a1e955e464

jonasschnelli added the Build system label Jun 16, 2016

jonasschnelli force-pushed the 2016/06/qt_561 branch from 8725277 to 802dc3d Compare June 16, 2016 18:51

jonasschnelli force-pushed the 2016/06/qt_561 branch 3 times, most recently from 953349e to 6b5e9d8 Compare June 17, 2016 06:41

theuni and others added 2 commits June 17, 2016 09:33

depends: bump OSX toolchain

f25209a

clang: 3.7.1 cctools: 877.8 ld64: 253.9

[depends] OpenSSL 1.0.1k - update config_opts

f6eb4e2

jonasschnelli force-pushed the 2016/06/qt_561 branch 2 times, most recently from 0f4d4cd to 737d78b Compare June 17, 2016 07:35

laanwj added this to the 0.13.0 milestone Jun 17, 2016

jonasschnelli force-pushed the 2016/06/qt_561 branch from 737d78b to dae7378 Compare June 17, 2016 11:56

Fix bitcoin_qt.m4 and fix-xcb-include-order.patch

6194d9a

jonasschnelli force-pushed the 2016/06/qt_561 branch from dae7378 to 6194d9a Compare June 17, 2016 13:56

jonasschnelli reviewed Jun 17, 2016
View reviewed changes

laanwj mentioned this pull request Sep 13, 2016

No notifications for transactions #8628

Closed

sickpig mentioned this pull request Jan 3, 2017

Fix qt gitian windows and linux BitcoinUnlimited/BitcoinUnlimited#199

Merged

schinzelh mentioned this pull request Oct 20, 2017

[WIP] Update build system to Bitcoin 0.13.2 dashpay/dash#1692

Closed

24 tasks

str4d mentioned this pull request Oct 29, 2017

Darwin build fixes zcash/zcash#2697

Merged

nexus166 mentioned this pull request Mar 1, 2018

Windows Wallet HiDPI (4k) Display Issue shane-kerr/Mintcoin-Desktop-Wallet#22

Open

strophy mentioned this pull request Dec 20, 2018

QT font issues no matter the display option dashpay/dash#2565

Closed

fanquake mentioned this pull request Jul 7, 2019

build: prune dbus from depends #16352

Merged

str4d mentioned this pull request Oct 6, 2019

Enable macOS cross-compilation zcash/zcash#4148

Merged

fanquake mentioned this pull request Nov 19, 2019

depends: only use D-Bus with Qt on linux #17521

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

[Qt] Bump to Qt5.6.1 #8210

[Qt] Bump to Qt5.6.1 #8210

Uh oh!

Conversation

jonasschnelli commented Jun 16, 2016

Uh oh!

jonasschnelli commented Jun 16, 2016

Uh oh!

sipa commented Jun 16, 2016

Uh oh!

jonasschnelli commented Jun 16, 2016

Uh oh!

laanwj commented Jun 17, 2016

Uh oh!

laanwj commented Jun 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli commented Jun 17, 2016

Uh oh!

laanwj commented Jun 17, 2016

Uh oh!

jonasschnelli commented Jun 17, 2016

Linux

MinGW

OSX

Uh oh!

jonasschnelli Jun 17, 2016

Choose a reason for hiding this comment

Uh oh!

fanquake commented Jun 17, 2016

Uh oh!

jonasschnelli commented Jun 17, 2016

Uh oh!

jonasschnelli commented Jun 17, 2016

Uh oh!

laanwj commented Jun 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theuni commented Jun 18, 2016 via email

Uh oh!

theuni commented Jun 18, 2016 via email

Uh oh!

theuni commented Jun 18, 2016 via email

Uh oh!

laanwj commented Jun 23, 2016

Uh oh!

maflcko commented Jul 8, 2016

Uh oh!

theuni commented Jul 8, 2016

Uh oh!

maflcko commented Jul 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

laanwj commented Jun 17, 2016 •

edited

Loading

laanwj commented Jun 18, 2016 •

edited

Loading