Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jun 15, 2016

Alternative to #8192

@maflcko maflcko added the Docs label Jun 15, 2016
@btcdrak
Copy link
Contributor

btcdrak commented Jun 15, 2016

We should also have a link to the project website.

@gmaxwell
Copy link
Contributor

Perhaps better to just link the website, in case we move off github in the future?

@btcdrak
Copy link
Contributor

btcdrak commented Jun 15, 2016

@gmaxwell agreed. The website address should be more permanent than the source repository which may or may not change in the future.

@maflcko
Copy link
Member Author

maflcko commented Jun 15, 2016

@btcdrak @gmaxwell I still think it is useful to have a link directly to the GitHub repo. I think there are no plans to move away from GitHub in the near future. Though, we may switch to the bitcoin-core organization some time...

Also, I have added two links to the website.

@maflcko maflcko changed the title [trivial] Add a link to the Bitcoin-Core repository to the About Dialog [trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog Jun 15, 2016
@sipa
Copy link
Member

sipa commented Jun 15, 2016

utACK

@sipa
Copy link
Member

sipa commented Jun 15, 2016

I think listing both the source code and the project website is a good idea.

src/init.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two %s can make the translation a bit hard in some languages where the order of words in the sentence is a bit different.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

Copy link
Member Author

@maflcko maflcko Jun 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone should write a macro that uses nested strprinf's, so you can use the number of %'s to indicate the precedence of the format specifier

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, worked around for now.

@btcdrak
Copy link
Contributor

btcdrak commented Jun 15, 2016

fine, but my personal preference would just link to "https://bitcoincore.org" rather than a specific page.

@paveljanik
Copy link
Contributor

Yes, just one link please. It would be also nice to not have About windows scrollable because of lot of texts.

@maflcko
Copy link
Member Author

maflcko commented Jun 15, 2016

screenshot from 2016-06-15 14-12-02

@btcdrak
Copy link
Contributor

btcdrak commented Jun 15, 2016

utACK fa6565d

@paveljanik
Copy link
Contributor

ACK fa6565d

@paveljanik
Copy link
Contributor

When you are in this file, can you change the http:// to https:// in the MIT link?

@maflcko maflcko added this to the 0.13.0 milestone Jun 15, 2016
@maflcko
Copy link
Member Author

maflcko commented Jun 15, 2016

@paveljanik Please mention this in #8192 (I can't change already translated strings as part of this pull anymore, as we are freezing translations tomorrow)

@paveljanik
Copy link
Contributor

@MarcoFalke ? You have just added the string "Please contribute if you..". So?

@maflcko
Copy link
Member Author

maflcko commented Jun 15, 2016

@paveljanik The problem is with already translated strings. Currently we have 161 project languages (27 without translators) and not even the German translations for 0.12 are fully done.

If you change a translated string, people would need to go through the about ~80 languages where it is already translated and apply the difference. This may or may not happen.

To sum up:

  • Having no translation is better than having no link to our websites at all.
  • Having a slightly outdated translation (e.g. a http link) is better than no translation at all.

@paveljanik
Copy link
Contributor

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

@jonasschnelli
Copy link
Contributor

Please squash.
ACK fa6565d2fc9c4cd8eac57915dc8b0aef8176b39c

@maflcko
Copy link
Member Author

maflcko commented Jun 16, 2016

@jonasschnelli: Squashed fa6565d into fa58e5e

@laanwj
Copy link
Member

laanwj commented Jun 16, 2016

Perhaps better to just link the website, in case we move off github in the future?

In that case we'll just update the software.

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

Unfortunately, no, we can't do that. Postprocessing the ts files is simple, but getting the data back to Transifex without breaking all their metadata is not.

utACK fa58e5e, this seems the best solution for 0.13 as we don't want to break translation strings.

@laanwj laanwj merged commit fa58e5e into bitcoin:master Jun 16, 2016
laanwj added a commit that referenced this pull request Jun 16, 2016
…website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)
@maflcko maflcko deleted the Mf1606-LicInfo branch June 16, 2016 08:58
codablock pushed a commit to codablock/dash that referenced this pull request Dec 28, 2017
…ry and website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
…ry and website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants