-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog #8207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should also have a link to the project website. |
|
Perhaps better to just link the website, in case we move off github in the future? |
|
@gmaxwell agreed. The website address should be more permanent than the source repository which may or may not change in the future. |
|
utACK |
|
I think listing both the source code and the project website is a good idea. |
src/init.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two %s can make the translation a bit hard in some languages where the order of words in the sentence is a bit different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone should write a macro that uses nested strprinf's, so you can use the number of %'s to indicate the precedence of the format specifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, worked around for now.
|
fine, but my personal preference would just link to "https://bitcoincore.org" rather than a specific page. |
|
Yes, just one link please. It would be also nice to not have About windows scrollable because of lot of texts. |
|
utACK fa6565d |
|
ACK fa6565d |
|
When you are in this file, can you change the http:// to https:// in the MIT link? |
|
@paveljanik Please mention this in #8192 (I can't change already translated strings as part of this pull anymore, as we are freezing translations tomorrow) |
|
@MarcoFalke ? You have just added the string "Please contribute if you..". So? |
|
@paveljanik The problem is with already translated strings. Currently we have 161 project languages (27 without translators) and not even the German translations for 0.12 are fully done. If you change a translated string, people would need to go through the about ~80 languages where it is already translated and apply the difference. This may or may not happen. To sum up:
|
|
Sure, but in the case of http -> https, we can simply postprocess the transifex files. |
|
Please squash. |
|
@jonasschnelli: Squashed fa6565d into fa58e5e |
In that case we'll just update the software.
Unfortunately, no, we can't do that. Postprocessing the ts files is simple, but getting the data back to Transifex without breaking all their metadata is not. utACK fa58e5e, this seems the best solution for 0.13 as we don't want to break translation strings. |
…website to the About Dialog fa58e5e [doc] Add website links to about dialog (MarcoFalke)
…ry and website to the About Dialog fa58e5e [doc] Add website links to about dialog (MarcoFalke)
…ry and website to the About Dialog fa58e5e [doc] Add website links to about dialog (MarcoFalke)

Alternative to #8192