Clarify documentation for running a tor node #8203
Conversation
doc/tor.md
Outdated
There was a problem hiding this comment.
Note that most distributions already have something along those lines, e.g. on Debian-based there is a debian-tor group, and you make cookie auth work by adding users who need it to the debian-tor group. I'd reword this to just say that you need to make sure the bitcoind user is part of the Tor group.
Anyone know how non-Debian distros do this?
There was a problem hiding this comment.
Yes, giving an example for Debian may help here.
There was a problem hiding this comment.
Added the example for Debian. Are we worried that the debian-tor group includes too many permissions outside of this one cookie permission we are interested in?
doc/tor.md
Outdated
There was a problem hiding this comment.
I'd reword this a bit - cookie authentication is by far the most straightforward (even automatic) if bitcoin core has access to tor's cookie file. This is the case on Windows with Tor Browser Bundle, for example. If not, then extra work is needed to set it up.
There was a problem hiding this comment.
Removed the opinion on simplicity.
doc/tor.md
Outdated
There was a problem hiding this comment.
Rather than saying "Tor automatically creates" how about we just say "On Debian-based systems the user running bitcoind can be added to the debian-tor group, which has the appropriate permissions." - Debian's package management is what's automatically creating debian-tor, not Tor itself.
There was a problem hiding this comment.
Much better wording.
doc/tor.md
Outdated
There was a problem hiding this comment.
No double spaces please :) We're not Satoshi.
Previous wording suggested that no additional setup was required for a tor hidden service to be created.
|
utACK 9e3ec74 |
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)
Tor ephemeral hidden services Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6503 (included to reduce merge conflicts) - bitcoin/bitcoin#6639 - bitcoin/bitcoin#6643 - bitcoin/bitcoin#7090 - bitcoin/bitcoin#7035 - bitcoin/bitcoin#7170 - bitcoin/bitcoin#7218 (non-QT part) - bitcoin/bitcoin#7313 - bitcoin/bitcoin#7438 - bitcoin/bitcoin#7553 - bitcoin/bitcoin#7637 - bitcoin/bitcoin#7683 - bitcoin/bitcoin#7813 - bitcoin/bitcoin#7703 - bitcoin/bitcoin#8203 - bitcoin/bitcoin#9004 - bitcoin/bitcoin#9234 - bitcoin/bitcoin#9911 (partial) Closes #2061.
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)
4 participants
Previous wording suggested that no additional setup was required for a tor hidden service to be created.
Discussed here: #8145