Skip to content

Conversation

@fanquake
Copy link
Member

This is being generated since #8188, should it be in .gitignore?

@maflcko maflcko added the Docs label Jun 13, 2016
@droark
Copy link
Contributor

droark commented Jun 14, 2016

Hmmm. Haven't run this but, going off my recollection of Gitian builds (haven't done one in awhile), all the stuff built in a Gitian container is self-contained and built away from the normal directory structure. So, I don't think this patch is necessary. Nice thought, though, and I could be totally wrong. :)

@sipa
Copy link
Member

sipa commented Jun 14, 2016 via email

@laanwj
Copy link
Member

laanwj commented Jun 14, 2016

@droark You would be right if split-debug.sh was only generated by the gitian descriptors. However the build system itself generates the file, so it does have to be ignored, as that's how we define the contents of .gitignore in this project.

(@sipa is right and it is not "necessary" to do so, however it prevents this generated file from accidentally being checked in)

@laanwj laanwj merged commit 01a9904 into bitcoin:master Jun 14, 2016
laanwj added a commit that referenced this pull request Jun 14, 2016
01a9904 [trivial] Ignore split-debug.sh (fanquake)
@droark
Copy link
Contributor

droark commented Jun 14, 2016

@laanwj @sipa - Thanks for the correction. What I meant with my original comment was that I was under the impression that the generated file wouldn't be picked up in the original directory, and that .gitignore didn't have to be updated. (Obviously, .gitignore and Gitian are unrelated. I didn't mean to imply that.) I was wrong, though. C'est la vie. :)

@fanquake fanquake deleted the ignore-split-debug branch June 22, 2016 02:54
codablock pushed a commit to codablock/dash that referenced this pull request Dec 28, 2017
01a9904 [trivial] Ignore split-debug.sh (fanquake)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
01a9904 [trivial] Ignore split-debug.sh (fanquake)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants