[trivial] Remove URLs from About dialog translations #8192
Conversation
|
ACK 78e3d1dcfed97eeb3db2f776e1683ed277098904 |
src/init.cpp
Outdated
There was a problem hiding this comment.
Please move the url out of the string to be translated.
There was a problem hiding this comment.
The URLs are used several lines down in the same file...
|
Concept ACK, |
|
@laanwj While we're editing the About dialog, should I remove the URLs from the other translations? |
|
If you do so, please remember to use |
|
Would be nice to have a link to the project website too, bitcoincore.org |
|
I think you can keep the other translations, as they already have great On Monday, June 13, 2016, Michael Ford [email protected] wrote:
|
fanquake
force-pushed
the
source-code-link
branch
from
78e3d1d to
0314ea7
Compare
|
We should aim to touch the translations only where necessary, as we're so close to a relase.
It's unfortunate that neither Qt nor strprintf has named variables in string interpolation like Python's |
src/init.cpp
Outdated
There was a problem hiding this comment.
Translation string freeze is in three days. Let's not invalidate all translations because the URL changed slightly. (The redirect still works fine)
Let's leave this for 0.14.0 or later. Also, the file name (COPYING) should be parametrized in the same go.
fanquake
force-pushed
the
source-code-link
branch
from
0314ea7 to
791b99d
Compare
|
I've updated this to include "COPYING". Seems that consensus is that this is to much of a burden on translators this close to a release, so lets tag for 0.14.0 and merge later? |
|
fanquake, what I was trying to say is that it would be fine to just add the
new line (with the link to our repo) but keep all other lines as they are
for now.
Adding the link could go into .13, all other can be done when we actually
got rid of the ossl prng. (maybe .14, maybe .15)
|
|
Should we merge this post 0.13 to not break the current translations? |
|
@jonasschnelli I think that's the best case. |
|
Assigned 0.14. Needs rebase. |
fanquake
force-pushed
the
source-code-link
branch
from
791b99d to
bdc74e4
Compare
fanquake
changed the title
|
rebased |
fanquake
force-pushed
the
source-code-link
branch
from
bdc74e4 to
208d37f
Compare
208d37f [trivial] Remove URLs from About dialog translations (fanquake)
208d37f [trivial] Remove URLs from About dialog translations (fanquake)
208d37f [trivial] Remove URLs from About dialog translations (fanquake)
…ctions f4691b6 tests: Add fuzzing harness for CKey related functions (practicalswift) Pull request description: Add fuzzing harness for `CKey` and key related functions. **How to test this PR** ``` $ make distclean $ ./autogen.sh $ CC=clang CXX=clang++ ./configure --enable-fuzz \ --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/key … #4096 pulse cov: 5736 ft: 6960 corp: 27/833b lim: 67 exec/s: 2048 rss: 122Mb #8192 pulse cov: 5736 ft: 6960 corp: 27/833b lim: 103 exec/s: 2048 rss: 143Mb #13067 NEW cov: 5736 ft: 6965 corp: 28/865b lim: 154 exec/s: 2177 rss: 166Mb L: 32/32 MS: 1 ChangeBit- #16384 pulse cov: 5736 ft: 6965 corp: 28/865b lim: 182 exec/s: 2048 rss: 181Mb #32768 pulse cov: 5736 ft: 6965 corp: 28/865b lim: 347 exec/s: 2184 rss: 258Mb … ``` Top commit has no ACKs. Tree-SHA512: 5b17ffb70c31966d3eac06d2258c127ae671d28d6cdf4e6ac20b45cd59ad32f80952c9c749930b97d317c72d5f840a3b75d466fd28fb6c351424a72c3e41bcbc
6 participants
Remove URLs from the strings in the About dialog.