Do not shadow variables in src/wallet #8191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wallet/db.cpp
Outdated
Member
There was a problem hiding this comment.
I'm not sure promoting these return values up to the function scope is a good idea. Keeping the scope of variables as small as possible ensures that results won't leak or accidentally influence other things.
Contributor
Author
There was a problem hiding this comment.
Technically speaking, this is not directly function scope.
But yes, one view is to have only one return value variable, the other is one return value variable per function call.
Renaming ret to ret1 here could make this particular change smaller.
Contributor
Author
There was a problem hiding this comment.
Done and squashed - now all the changes are of the same kind.
paveljanik
force-pushed
the
20160611_shadowing_wallet
branch
from
0aa5728 to
d5b25fa
Compare
Member
|
ACK: |
Contributor
Author
|
more ACKs please |
Member
|
utACK d5b25fa5792b3899759a73059a87c6b015fc8535 |
8 tasks
paveljanik
force-pushed
the
20160611_shadowing_wallet
branch
from
d5b25fa to
b175cb7
Compare
Contributor
Author
|
Rebased. |
Member
|
Also compared binaries, tACK b175cb7 |
laanwj
added a commit
that referenced
this pull request
Aug 31, 2016
b175cb7 Do not shadow variables. (Pavel Janík)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 9, 2018
b175cb7 Do not shadow variables. (Pavel Janík)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 9, 2018
b175cb7 Do not shadow variables. (Pavel Janík)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
b175cb7 Do not shadow variables. (Pavel Janík)
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2020
…refactor. 58504c2 [Wallet] refactor CWallet/CWalletDB/CDB (Round 2) (furszy) c16390d [Wallet] refactor CWallet/CWalletDB/CDB (Round 1) (furszy) 99adac0 C++11: s/boost::scoped_ptr/std::unique_ptr/ (furszy) 815773e use constant references for strings in functions in wallet/*.* (furszy) 24f1041 Do not shadow variables. (Pavel Janík) 6a0c59a wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan) 12bc297 dbwrapper: Use new .data() method of CDataStream (Wladimir J. van der Laan) b0f0d91 streams: Remove special cases for ancient MSVC (Wladimir J. van der Laan) ba96777 streams: Add data() method to CDataStream (Wladimir J. van der Laan) 6ec0722 wallet: Use CDataStream.data() (Wladimir J. van der Laan) ca1a3b0 [Wallet] remove unused code/conditions in ReadAtCursor (Jonas Schnelli) fd259f3 remove unused classes from db.h (Philip Kaufmann) Pull request description: Upgrading the wallet, wallet db and db wrapper areas with several back ports and updates adaptations. List of PRs: * dashpay#5933 * bitcoin#7537 * bitcoin#8191 * bitcoin#8564 * bitcoin#8574 * bitcoin#8629 * bitcoin#9353 Note: Low priority PR, can be reviewing after merge Sapling and tier two PRs. I made it because we are pretty far from upstream in the db area and want to introduce some new functionality in the future that requires a more up-to-date db layer. ACKs for top commit: random-zebra: ACK 58504c2 and merging... Tree-SHA512: e5a700e855bcec20f0b74e41825ddc3a36b56a0cbe83212c93d212c06765254464999567b395584dfeb9d4b12999bc835d2e89949684d64b1503db36c53fd3c8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #8105.
Review of this should be pretty straight forward. Just compare binaries. View the diff in visual diff or so.
To provide tested ACK, cherrypick paveljanik/bitcoin@5d2f98e and compare master build log and this PR build log.