wallet: Add key generation type #8132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A encrypted wallet can still hold keys which where created when the wallet was unencrypted. This PR will add a 8bit-flags-int to the CKeyMetadata class. `listreceivedbyaddress` will report whether the key was generated within a enctypted wallet or if it was imported throught `importprivkey`
Contributor
|
Hmm... we never have deployed #5916 (I guess you did in your custom distribution?). This would mean 104ab31 would address a feature-compatibility between third party distribution. My preferred solution would be:
PR nit: |
Member
Author
|
I called it "OLD" rather than "8BIT" because there's a bitshift involved. Any idea what's up with Travis's Mac build? :/ |
Member
|
I'd prefer to not include migration code for something that we never deployed. |
Member
Author
|
Superceded by #8471 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #5916 by adding backward compatibility with existing wallets