Bugfix: use global ::fRelayTxes instead of CNode in version send #8102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'll work on a better test for this, but I propose merging quickly, as relay of transactions is currently broken in master. |
Member
|
yikes. utACK. As an aside, we should really strive to avoid shadowing vars, and enable -Wshadow. Also, as a follow-up, this should probably be renamed fBlocksonly so that it's more clear what it's for. |
sipa
added a commit
that referenced
this pull request
May 26, 2016
…ion send 52b02ec Use global ::fRelayTxes instead of CNode one (Pieter Wuille)
8 tasks
Member
|
Good catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8049 changed the calls to GetBoolArg("-blocksonly") to a global boolean
fRelayTxes. InsideCNode::PushVersion,fRelayTxesrefers to the CNode instance variable with the same name, however, causing the connecting node to always send false here, and never receive any transactions.I've attempted to add a unit test for this, but we don't seem to ever test receiving relayed transactions by a connecting node only...