Adding P2SH(p2pkh) script test case #8090
Conversation
|
Please squash into one commit (see 90963e5#diff-6a3371457528722a734f3c51d9238c13R46). |
Christewart
force-pushed
the
add_p2sh_p2pkh_script_test
branch
from
987d378 to
32833a4
Compare
|
Not sure why Travis CI failed on this build - I don't know Travis CI that well but it looks like it is unrelated to my change? |
|
Agree that the failure looks unrelated. But yikes, that looks like a somewhat scary error that was stumbled upon, will investigate... |
|
ACK 32833a4 Travis failure is indeed unrelated. |
|
@paveljanik @sdaftuar Is there a way to restart this travis build? |
|
Lokks like it is already done - all checks have passed. |
|
@Christewart Please don't add manually created test cases inside the "automically generated test cases" block, as that block gets overwritten. Ideally, add this as an automatically generated test here: https://github.com/bitcoin/bitcoin/blob/v0.12.1/src/test/script_tests.cpp#L353 |
Christewart
force-pushed
the
add_p2sh_p2pkh_script_test
branch
from
2ed49f5 to
266f60a
Compare
src/test/script_tests.cpp
Outdated
|
Sorry for this taking so long, just moving the test case would have been fine, but now that you change script_tests.cpp you need to make sure it doesn't generate the new json every time. |
Fixing formatting Adding test case into automatically generated test case set Clean up commits removing extra whitespace from eol Removing extra whitespace on macro line
Christewart
force-pushed
the
add_p2sh_p2pkh_script_test
branch
from
266f60a to
b682960
Compare
|
@laanwj Should be fixed - I always seem to add unnecessary spaces/new lines without realizing it in my commits :-) |
|
utACK b682960 |
| "P2SH(P2PK), bad redeemscript", SCRIPT_VERIFY_P2SH, true | ||
| ).PushSig(keys.key0).PushRedeem().DamagePush(10).ScriptError(SCRIPT_ERR_EVAL_FALSE)); | ||
|
|
||
|
|
There was a problem hiding this comment.
Pure cosmetic nit: you have added tab here.
There was a problem hiding this comment.
Nit^2: I think it's not a tab but four spaces 🐌
|
utACK b682960 |
b682960 Adding P2SH(p2pkh) script test case (Chris Stewart)
|
Not going to hold this up on a cosmetic nit. |
b682960 Adding P2SH(p2pkh) script test case (Chris Stewart)
b682960 Adding P2SH(p2pkh) script test case (Chris Stewart)
6 participants
The happy path for a p2sh script with redeem script type p2pkh was previously untested, adding a test case for this inside of script_tests.json