Add req- prefixes to comply with BIP21. #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No, the original intent was that req- prefixes are optional and can be applied to any params. ie a merchant may want to enforce or not enforce an expires param. That should be clarified in the bip. (see genjix/bips#4) |
Member
|
In that case should there be a in the |
Contributor
Author
|
Heh, oops...fixed |
Contributor
|
This is the type of code that aught to have unit tests. I don't know nuthin about unit testing with Qt; is it easy to get qmake to compile unit tests, and/or is there support in Qt for unit tests? |
Contributor
Author
|
Still gotta add a ton more test, but I put in a bitcoin-qt test suite structure. Just build with |
Contributor
Author
|
OK, there we go, test away. |
Member
|
ACK, nice tests |
laanwj
added a commit
that referenced
this pull request
Feb 12, 2012
Add req- prefixes to comply with BIP21.
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
Add req- prefixes to comply with BIP21.
destenson
pushed a commit
to destenson/bitcoin--bitcoin
that referenced
this pull request
Jun 26, 2016
Rebranding: PrivateSend/InstantSend (update 2d)
ghost
mentioned this pull request
pull bot
referenced
this pull request
in jaschadub/bitcoin
Jul 8, 2019
d003110 Remove unused guard (Hennadii Stepanov) Pull request description: `BITCOIN_QT_TEST` is no longer used since switching to autotools build system. Some historical refs: - #807 - bitcoin#4241 ACKs for top commit: practicalswift: utACK d003110 promag: ACK d003110. jonasschnelli: Verified ACK d003110 Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 9, 2020
Summary: PR description: > BITCOIN_QT_TEST is no longer used since switching to autotools build system. > > Some historical refs: > > bitcoin/bitcoin#807 > bitcoin/bitcoin#4241 Backport of Core [[bitcoin/bitcoin#16350 | PR16350]] Test Plan: ``` grep -r BITCOIN_QT_TEST[^_] . cd build ninja && ninja check ``` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7846
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.