travis: use slim generic image, and some fixups #8067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK. Travis failure is extremely scary: |
Member
.travis.yml
Outdated
Member
There was a problem hiding this comment.
I've already merged this, because I am not sure how long this pull will be in the review queue.
You could try a rebase once travis is running again to get rid of this patch and also trigger a build.
theuni
force-pushed
the
travis-generic-image
branch
from
86b66da to
957f895
Compare
Now that caches are distinct (travis-ci/travis-ci#4393), we can use the Travis minimal image. The minimal image should take less time to setup and lead to quicker builds. Also addressed while I'm in here: - No need to delete the broken google-chrome repo in the minimal image - Set the hostname to work-around an openjdk bug - Remove the non-functional apt-cache option - Remove useless message at completion - Install jre where the java tests are run
theuni
force-pushed
the
travis-generic-image
branch
from
957f895 to
9063c64
Compare
Contributor
|
Can one of the admins verify this patch? |
Member
|
Looks like the workaround for the work-around is still failing travis :( |
Member
|
Tried to retrigger travis, still fails |
theuni
force-pushed
the
travis-generic-image
branch
from
9063c64 to
2ca8962
Compare
Member
Author
|
Ready for review now, the upstream issue has been resolved. |
Member
|
Travis results look good @ https://travis-ci.org/bitcoin/bitcoin/builds/136465746. |
laanwj
added a commit
that referenced
this pull request
Jun 10, 2016
2ca8962 travis: use slim generic image, and some fixups (Cory Fields)
Member
|
Post merge utACK 2ca8962 |
24 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that caches are distinct (travis-ci/travis-ci#4393), we can use the Travis minimal image. The minimal image should take less time to setup and lead to quicker builds.
Also addressed while I'm in here: