Skip to content

Conversation

@pstratem
Copy link
Contributor

@pstratem pstratem commented May 17, 2016

Improvements to the CWallet API which can be made without a negative performance impact.

@pstratem pstratem force-pushed the 2016-05-14-wallet-api-cleanup branch 2 times, most recently from 0826df7 to 380498a Compare May 17, 2016 00:57
@dcousens
Copy link
Contributor

dcousens commented May 17, 2016

utACK 380498a

On another note, CWallet is doing way too much at this point.
The movement of these functions into CWallet fall under its current responsibilities, it just simply has too many responsibilities.
No doubt we're quite the stones throw away from it following the single responsibility principle haha.

@jonasschnelli
Copy link
Contributor

utACK 380498a

@maflcko
Copy link
Member

maflcko commented May 17, 2016

utACK 380498a

@paveljanik
Copy link
Contributor

ACK 380498a

@arowser
Copy link
Contributor

arowser commented May 25, 2016

Can one of the admins verify this patch?

@sipa
Copy link
Member

sipa commented May 25, 2016

ACK, Confirmed move-only ecb9741 and 380498a.

@sipa sipa merged commit 380498a into bitcoin:master May 25, 2016
sipa added a commit that referenced this pull request May 25, 2016
380498a Move BackupWallet to CWallet::BackupWallet (Patrick Strateman)
ecb9741 Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance (Patrick Strateman)
codablock pushed a commit to codablock/dash that referenced this pull request Dec 21, 2017
380498a Move BackupWallet to CWallet::BackupWallet (Patrick Strateman)
ecb9741 Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance (Patrick Strateman)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants