Expose information on whether transaction relay is enabled in getnetwork
#8049
Conversation
Add a fRelayTxes to keep track of the relay transaction flag we send to other peers.
Re-work of PR bitcoin#7841 by dragongem45. Closes bitcoin#7771.
laanwj
changed the title
getnetworkgetnetwork
| " \"subversion\": \"/Satoshi:x.x.x/\", (string) the server subversion string\n" | ||
| " \"protocolversion\": xxxxx, (numeric) the protocol version\n" | ||
| " \"localservices\": \"xxxxxxxxxxxxxxxx\", (string) the services we offer to the network\n" | ||
| " \"localrelay\": true|false, (bool) true if transaction relay is requested from peers\n" |
There was a problem hiding this comment.
What does "transaction relay is requested from peers" mean? Shouldn't this say "true if transaction relay is enabled locally"?
There was a problem hiding this comment.
Possibly - What the flag is used for is to specify in the version message whether we want to receive transactions (so whether transactions should be relayed to us), as well as in the network code whether we accept transactions. That we don't relay transactions is also true, but follows from that.
Maybe the naming is confusing, but I don't know a better one either.
There was a problem hiding this comment.
Maybe "true if we do not want to send or receive transactions"? But consider it a nit, I am not a native speaker ;)
|
utACK 1ab1dc3 |
1 similar comment
|
utACK 1ab1dc3 |
|
utACK |
|
utACK 1ab1dc3 |
| fListen = GetBoolArg("-listen", DEFAULT_LISTEN); | ||
| fDiscover = GetBoolArg("-discover", true); | ||
| fNameLookup = GetBoolArg("-dns", DEFAULT_NAME_LOOKUP); | ||
| fRelayTxes = !GetBoolArg("-blocksonly", DEFAULT_BLOCKSONLY); |
There was a problem hiding this comment.
nit: why the "e" between the "x" and "s"?
6 participants
Re-work of #7841 by @dragongem45.
Closes #7771.