Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented May 10, 2016

In my ever-growing list of test failures, I was seeing this one intermittently.

```
Running 2nd level testscript pruning.py...
Initializing test directory /tmp/testY5ypCv
Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours)
Mining a big blockchain of 995 blocks
Check that we haven't started pruning yet because we're below PruneAfterHeight
Success
Though we're already using more than 550MB, current usage: 587
Mining 25 more blocks should cause the first block file to be pruned
Assertion failed: blk00000.dat not pruned when it should be
  File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main
    self.run_test()
  File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test
    self.test_height_min()
  File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min
    raise AssertionError("blk00000.dat not pruned when it should be")
Stopping nodes
Failed
```

After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds.

I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short.

After changing the timeout to 30 seconds, the test passes consistently.
(cherry picked from commit 3469911)
@maflcko maflcko force-pushed the Mf1605-trivial12 branch from facf059 to fa4458e Compare May 10, 2016 15:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/blochchain/blockchain/

@maflcko maflcko force-pushed the Mf1605-trivial12 branch from fa4458e to fa83a5d Compare May 10, 2016 16:09
@laanwj
Copy link
Member

laanwj commented May 12, 2016

utACK

@fanquake
Copy link
Member

utACK

@maflcko maflcko added Tests and removed Refactoring labels May 14, 2016
@maflcko maflcko merged commit fa83a5d into bitcoin:master May 17, 2016
maflcko pushed a commit that referenced this pull request May 17, 2016
fa83a5d [qa] wallet: Temporarily disable salvagewallet test (MarcoFalke)
fadd048 [doc] Link to clang-format in the developer notes (MarcoFalke)
fa72f7d [doc] Remove outdated line from listunspent RPC help, fix typo (MarcoFalke)
ac40ed7 Increase timeout waiting for pruned blk00000.dat (error10)
@maflcko maflcko deleted the Mf1605-trivial12 branch May 17, 2016 07:27
ftrader added a commit to ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu that referenced this pull request Dec 9, 2016
This is a merge of bitcoin/bitcoin#7744 / MVF-Core PR#16.

Instead of freezing up qa tests, wallet.py will fail on some 32-bit platforms where wallet salvage operation sometimes fails due to unknown reasons.

See also: bitcoin/bitcoin#7463 about the -salvagewallet problem.

Core has decided to disable the salvage part of the test in bitcoin/bitcoin#8038 , we may implement a Skip() of this test on 32-bit or disable that test step in a similar way.
The wallet salvage problem is definitely unrelated to any fork programming.
codablock pushed a commit to codablock/dash that referenced this pull request Dec 21, 2017
fa83a5d [qa] wallet: Temporarily disable salvagewallet test (MarcoFalke)
fadd048 [doc] Link to clang-format in the developer notes (MarcoFalke)
fa72f7d [doc] Remove outdated line from listunspent RPC help, fix typo (MarcoFalke)
ac40ed7 Increase timeout waiting for pruned blk00000.dat (error10)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants