Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented May 3, 2016

miniupnpc 2.0 changelog
expat 2.1.1 changelog
freetype 2.6.3, changelog, change download url to the mirror at gnu.org
ccache 3.2.5 changelog
zeromq 4.1.4 changelog
Latest config.guess & config.sub

@theuni
Copy link
Member

theuni commented May 3, 2016

adding "--without-libsodium" should fix the zmq build, by the looks

@fanquake fanquake force-pushed the depends-no-sourceforge branch from dad4449 to 2b9361b Compare May 4, 2016 01:37
@fanquake fanquake force-pushed the depends-no-sourceforge branch 4 times, most recently from 0074ea1 to 6696665 Compare May 10, 2016 03:56
@fanquake
Copy link
Member Author

Rebased onto master, and should have fixed the ZeroMQ build issues (needed --without-libsodium and no longer need to look in the src dir)

@fanquake
Copy link
Member Author

Added two additional commits updating miniupnpc and expat
Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

miniupnpc changelog

@fanquake fanquake force-pushed the depends-no-sourceforge branch 2 times, most recently from 843ad16 to ad4a9f3 Compare May 18, 2016 13:17
@laanwj
Copy link
Member

laanwj commented May 20, 2016

utACK

Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

Oh! I see expat is used indirectly through dbus. Already wondered what we were using a XML parsing library for.
Wonder if any of that code ends up in the executable or it's just used for dbus' build tools.

@fanquake fanquake changed the title [depends] Update FreeType, ccache, ZeroMQ [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat May 21, 2016
@sipa
Copy link
Member

sipa commented Jun 1, 2016

Concept ACK. I haven't checked the hashes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use:
$(MAKE) libzmq.la to avoid building stuff other than the lib

@theuni
Copy link
Member

theuni commented Jun 1, 2016

@laanwj Yes, through dbus and fontconfig. Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Still need it for fontconfig though :(

@theuni
Copy link
Member

theuni commented Jun 1, 2016

utACK, with the exception of the two nits.

fanquake added 6 commits June 2, 2016 09:16
Update FreeType, and change the download location to gnu.org. This is
the other official download location listed on freetype.org
@fanquake fanquake mentioned this pull request Jun 2, 2016
1 task
@fanquake fanquake force-pushed the depends-no-sourceforge branch from ad4a9f3 to 6a4cf16 Compare June 2, 2016 01:36
@fanquake
Copy link
Member Author

fanquake commented Jun 2, 2016

Nits addressed, and rebased on master

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

@laanwj
Copy link
Member

laanwj commented Jun 8, 2016

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

No urgency in bumping. But removal that should be discussed separately. We do use dbus for the notification stuff in the Qt GUI, so there are (minor) consequences for users.

@laanwj
Copy link
Member

laanwj commented Jun 8, 2016

Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Oh I missed that part. Yes makes sense to remove it then.

@laanwj
Copy link
Member

laanwj commented Jun 8, 2016

utACK 6a4cf16

@laanwj laanwj merged commit 6a4cf16 into bitcoin:master Jun 8, 2016
laanwj added a commit that referenced this pull request Jun 8, 2016
6a4cf16 [depends] expat 2.1.1 (fanquake)
3e0587b [depends] miniupnpc 2.0 (fanquake)
87b8175 [depends] Latest config.guess & config.sub (fanquake)
bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake)
0385202 [depends] ccache 3.2.5 (fanquake)
2b2d52e [depends] Freetype 2.6.3 (fanquake)
@fanquake fanquake mentioned this pull request Jun 17, 2016
@fanquake fanquake deleted the depends-no-sourceforge branch June 22, 2016 08:38
zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017
zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017
codablock pushed a commit to codablock/dash that referenced this pull request Dec 22, 2017
…c, expat

6a4cf16 [depends] expat 2.1.1 (fanquake)
3e0587b [depends] miniupnpc 2.0 (fanquake)
87b8175 [depends] Latest config.guess & config.sub (fanquake)
bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake)
0385202 [depends] ccache 3.2.5 (fanquake)
2b2d52e [depends] Freetype 2.6.3 (fanquake)
laanwj added a commit that referenced this pull request Jul 8, 2019
e8fabd9 build: prune dbus from depends (fanquake)

Pull request description:

  Since #8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt.

  ```
  qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus
    -no-dbus ............. Do not build the Qt D-Bus module
    -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto]
    -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no]
  ```

  This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](#7993 (comment)) and [here](#8210 (comment)), but was never followed up. dongcarl also bought it up as part of #16150.

  I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing.

ACKs for top commit:
  laanwj:
    code review ACK e8fabd9

Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 9, 2019
e8fabd9 build: prune dbus from depends (fanquake)

Pull request description:

  Since bitcoin#8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt.

  ```
  qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus
    -no-dbus ............. Do not build the Qt D-Bus module
    -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto]
    -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no]
  ```

  This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](bitcoin#7993 (comment)) and [here](bitcoin#8210 (comment)), but was never followed up. dongcarl also bought it up as part of bitcoin#16150.

  I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing.

ACKs for top commit:
  laanwj:
    code review ACK e8fabd9

Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20
monstrobishi pushed a commit to DeFiCh/ain that referenced this pull request Sep 6, 2020
e8fabd9 build: prune dbus from depends (fanquake)

Pull request description:

  Since #8210 (59d063d), we've been passing `-dbus-runtime` when configuring Qt.

  ```
  qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus
    -no-dbus ............. Do not build the Qt D-Bus module
    -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto]
    -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no]
  ```

  This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](bitcoin/bitcoin#7993 (comment)) and [here](bitcoin/bitcoin#8210 (comment)), but was never followed up. dongcarl also bought it up as part of #16150.

  I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing.

ACKs for top commit:
  laanwj:
    code review ACK e8fabd9

Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants