CDataStream::ignore Throw exception instead of assert on negative nSize. #7936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstratem
force-pushed
the
2016-04-24-cdatastream-ignore
branch
from
d3c728a to
2ed0ca4
Compare
Previously disk corruption would cause an assert instead of an exception.
Member
|
Concept ACK. How do the call-sites of this function cope with this exception? I suppose this is only used in reindexing? |
Member
|
There are actually no call sites for this before #7933... |
Contributor
Author
|
CDataStream::ignore -> CScriptCompressor::Unserialize -> CTxOutCompressor::SerializationOp CCoins::GetSerializeSize,Serialize,Unserialize Still working on what calls those... |
pstratem
changed the title
pstratem
changed the title
Member
Contributor
Author
|
@sipa Indeed since this can only be triggered by disk corruption... all bets are off anyways |
Member
|
Merged as part of #7933 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously disk corruption would cause an assert instead of an exception.
This has not been extensively reviewed.