Use txid as key in mapAlreadyAskedFor #7862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used the CInv that would be sent to the peer announcing the transaction as the key, but using the txid instead allows us to decouple the p2p layer from the application logic (which relies on this map to avoid duplicate tx requests).
Contributor
|
utACK 7e91f63 |
Member
|
utACK 7e91f63 |
Member
|
utACK 7e91f63 |
1 similar comment
Contributor
|
utACK 7e91f63 |
Member
|
Should be tagged with "Backport 0.12.2" if this is meant for segwit. |
Member
Author
|
@MarcoFalke Agreed, thanks for pointing that out. |
Member
|
Makes sense to me. |
laanwj
added a commit
that referenced
this pull request
Apr 14, 2016
7e91f63 Use txid as key in mapAlreadyAskedFor (Suhas Daftuar)
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 27, 2016
Previously we used the CInv that would be sent to the peer announcing the transaction as the key, but using the txid instead allows us to decouple the p2p layer from the application logic (which relies on this map to avoid duplicate tx requests). Github-Pull: bitcoin#7862 Rebased-From: 7e91f63
Member
|
Backported as part of #7938. Removing label 'Needs backport'. |
thokon00
pushed a commit
to faircoin/faircoin
that referenced
this pull request
Jun 28, 2016
Previously we used the CInv that would be sent to the peer announcing the transaction as the key, but using the txid instead allows us to decouple the p2p layer from the application logic (which relies on this map to avoid duplicate tx requests). Github-Pull: bitcoin#7862 Rebased-From: 7e91f63
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Aug 4, 2021
ZIP 239 preparations 1 This is the first of several backports to prepare for ZIP 239. The primary change is altering `mapRelay` to store `CTransaction`s, which we need because ZIP 239 requires changing `Inv` messages based on transaction versions. The other changes are mainly for conflict removal but are also independently useful. Backports the following upstream PRs: - bitcoin/bitcoin#6889 - bitcoin/bitcoin#7125 - bitcoin/bitcoin#7862 - bitcoin/bitcoin#7877
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Aug 5, 2021
ZIP 239 preparations 1 This is the first of several backports to prepare for ZIP 239. The primary change is altering `mapRelay` to store `CTransaction`s, which we need because ZIP 239 requires changing `Inv` messages based on transaction versions. The other changes are mainly for conflict removal but are also independently useful. Backports the following upstream PRs: - bitcoin/bitcoin#6889 - bitcoin/bitcoin#7125 - bitcoin/bitcoin#7862 - bitcoin/bitcoin#7877
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Aug 10, 2021
ZIP 239 preparations 1 This is the first of several backports to prepare for ZIP 239. The primary change is altering `mapRelay` to store `CTransaction`s, which we need because ZIP 239 requires changing `Inv` messages based on transaction versions. The other changes are mainly for conflict removal but are also independently useful. Backports the following upstream PRs: - bitcoin/bitcoin#6889 - bitcoin/bitcoin#7125 - bitcoin/bitcoin#7862 - bitcoin/bitcoin#7877
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the
CInvthat would be sent to the peer announcing the transaction as the key, but using the txid instead allows us to decouple the p2p layer from the application logic.This is a minor preparatory commit for segwit, in which the inv-type will no longer be the same for all transaction requests.