Only send one GetAddr response per connection. #7856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conserves resources from abusive peers that just send getaddr in a loop. Also makes correlating addr messages against INVs less effective.
Contributor
|
utACK 66b0724 |
Contributor
|
utACK 66b0724 |
Member
|
utACK 66b0724 |
| // Only send one GetAddr response per connection to reduce resource waste | ||
| // and discourage addr stamping of INV announcements. | ||
| if (pfrom->fSentAddr) { | ||
| LogPrint("net", "Ignoring repeated \"getaddr\". peer=%d\n", pfrom->id); |
Contributor
There was a problem hiding this comment.
Cosmetic nits: The dot before peer looks ugly, but the same style is used above (getaddr from outbound connection). The space in the comment in the second line, before the word "and" is unintentional?
Contributor
|
ACK 66b0724 |
Member
|
utACK 66b0724 |
Member
|
Good idea. |
laanwj
added a commit
that referenced
this pull request
Apr 15, 2016
66b0724 Only send one GetAddr response per connection. (Gregory Maxwell)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 20, 2017
66b0724 Only send one GetAddr response per connection. (Gregory Maxwell)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conserves resources from abusive peers that just send
getaddr in a loop. Also makes correlating addr messages
against INVs less effective.