Prevent multiple calls to ExtractDestination #7825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobranco
force-pushed
the
enhancement/prevent-multiple-calls-extractdestination
branch
from
47aeacf to
4a7c2f4
Compare
Contributor
|
utACK 4a7c2f4 |
Member
|
Concept ACK |
Contributor
|
ACK 4a7c2f4 To get more people looking at this, please provide some interesting numbers ;-)) |
Contributor
Author
|
The performance improvement isn't much significant on typical wallets. The main advantage is the reuse of the function |
Contributor
|
I would add this condition so it is equivalent to before: |
Contributor
Author
|
@NicolasDorier You are right. Will fix. |
pedrobranco
force-pushed
the
enhancement/prevent-multiple-calls-extractdestination
branch
2 times, most recently
from
fd70385 to
83153e6
Compare
Contributor
|
utACK 83153e6 (nit: redeemScript does not appear in the help message.) |
pedrobranco
force-pushed
the
enhancement/prevent-multiple-calls-extractdestination
branch
from
83153e6 to
289bb60
Compare
pedrobranco
force-pushed
the
enhancement/prevent-multiple-calls-extractdestination
branch
from
289bb60 to
0bf6f30
Compare
Member
|
utACK 0bf6f30 |
Contributor
|
Core-Review utACK 0bf6f30 |
sipa
added a commit
that referenced
this pull request
Jun 2, 2016
0bf6f30 Prevent multiple calls to ExtractDestination (Pedro Branco)
pedrobranco
deleted the
enhancement/prevent-multiple-calls-extractdestination
branch
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 22, 2017
0bf6f30 Prevent multiple calls to ExtractDestination (Pedro Branco)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 23, 2018
Bech32 encoding support and t-addr encoding refactor Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` - bitcoin/bitcoin#11117 - bitcoin/bitcoin#11259 - bitcoin/bitcoin#11167 - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific). Part of #3058.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
May 1, 2018
Upstream encoding cleanups Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` Precursor to #3202.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
May 1, 2018
Upstream encoding cleanups Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` Precursor to #3202.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
0bf6f30 Prevent multiple calls to ExtractDestination (Pedro Branco)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial performance improvement.
It consists in preventing multiple calls to
ExtractDestinationin rpc calllistunspent. For an large UTXO set the improvement are more notable.This PR moves the computation of multiple
ExtractDestinationto a single call, and also reorganizes the code of building the JSON result of each UTXO.