init: allow shutdown during 'Activating best chain...' #7821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two-line patch to make it possible to shut down bitcoind cleanly during the initial ActivateBestChain. Fixes bitcoin#6459 (among other complaints). To reproduce: - shutdown bitcoind - copy chainstate - start bitcoind - let the chain sync a bit - shutdown bitcoind - copy back old chainstate - start bitcoind - bitcoind will catch up with all blocks during Init() (the `boost::this_thread::interruption_point` / `ShutdownRequested()` dance is ugly, this should be refactored all over bitcoind at some point when moving from boost::threads to c++11 threads, but it works...)
Contributor
|
utACK 07398e8 |
Contributor
|
concept ACK, utACK 07398e8 |
Member
|
utACK 07398e8 |
laanwj
added a commit
that referenced
this pull request
Apr 7, 2016
07398e8 init: allow shutdown during 'Activating best chain...' (Wladimir J. van der Laan)
laanwj
added a commit
that referenced
this pull request
Apr 7, 2016
Two-line patch to make it possible to shut down bitcoind cleanly during the initial ActivateBestChain. Fixes #6459 (among other complaints). To reproduce: - shutdown bitcoind - copy chainstate - start bitcoind - let the chain sync a bit - shutdown bitcoind - copy back old chainstate - start bitcoind - bitcoind will catch up with all blocks during Init() (the `boost::this_thread::interruption_point` / `ShutdownRequested()` dance is ugly, this should be refactored all over bitcoind at some point when moving from boost::threads to c++11 threads, but it works...) Github-Pull: #7821 Rebased-From: 07398e8
zander
pushed a commit
to bitcoinclassic/bitcoinclassic
that referenced
this pull request
Apr 22, 2016
Two-line patch to make it possible to shut down bitcoind cleanly during the initial ActivateBestChain. Fixes bitcoin#6459 (among other complaints). To reproduce: - shutdown bitcoind - copy chainstate - start bitcoind - let the chain sync a bit - shutdown bitcoind - copy back old chainstate - start bitcoind - bitcoind will catch up with all blocks during Init() (the `boost::this_thread::interruption_point` / `ShutdownRequested()` dance is ugly, this should be refactored all over bitcoind at some point when moving from boost::threads to c++11 threads, but it works...) Github-Pull: bitcoin#7821 Rebased-From: 07398e8
thokon00
pushed a commit
to faircoin/faircoin
that referenced
this pull request
Jun 28, 2016
Two-line patch to make it possible to shut down bitcoind cleanly during the initial ActivateBestChain. Fixes bitcoin#6459 (among other complaints). To reproduce: - shutdown bitcoind - copy chainstate - start bitcoind - let the chain sync a bit - shutdown bitcoind - copy back old chainstate - start bitcoind - bitcoind will catch up with all blocks during Init() (the `boost::this_thread::interruption_point` / `ShutdownRequested()` dance is ugly, this should be refactored all over bitcoind at some point when moving from boost::threads to c++11 threads, but it works...) Github-Pull: bitcoin#7821 Rebased-From: 07398e8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two-line patch to make it possible to shut down bitcoind cleanly during the initial ActivateBestChain.
Fixes #6459 (among other complaints).
To reproduce:
(the
boost::this_thread::interruption_point/ShutdownRequested()dance is ugly, this should be refactored all over bitcoind at some point when moving from boost::threads to c++11 threads, but it works...)