RPC: fix generatetoaddress failing to parse address #7797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK |
Member
|
How come the rpc test pass without this fix? |
Member
|
The RPC tests don't use bitcoin-cli. At all. |
Member
|
The RPC tests do the conversion to JSON on the python side, I think; they
don't use bitcoin-cli (which is where the bug is).
|
Member
|
I also think that is right: the RPC tests test the RPC server, so should be using it directly. Ofc it may be good to have a few separate tests for bitcoin-cli. Or a unit test for function |
mruddy
force-pushed
the
generatetoaddress-fix
branch
from
199dc2e to
60361ca
Compare
Contributor
Author
|
added a unit test calling |
Member
|
@mruddy That's awesome! |
laanwj
added a commit
that referenced
this pull request
Apr 3, 2016
60361ca RPC: fix generatetoaddress failing to parse address and add unit test (mruddy)
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Feb 20, 2017
60361ca RPC: fix generatetoaddress failing to parse address and add unit test (mruddy)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
60361ca RPC: fix generatetoaddress failing to parse address and add unit test (mruddy)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new RPC
generatetoaddressdidn't seem to work for me both from the command line and from the Qt debug window console.This change makes it work for me.
For example, I kept getting similar to this (I tried various quoting etc... too):
Reference: #7671