Put hex-encoded version in UpdateTip #7763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Maybe %08x? |
sipa
force-pushed
the
hexver
branch
2 times, most recently
from
2b6357c to
b738799
Compare
Member
Author
|
Updated to use version=0x%08x |
Member
|
utACK b738799 |
sipa
changed the title
Member
Author
|
Renamed the pull request, as I noticed it wasn't accurate: there was no nVersion in that message before |
Contributor
|
utACK b738799 |
Contributor
|
Nice. |
src/main.cpp
Outdated
Contributor
There was a problem hiding this comment.
version=0x%08x here too?
Member
There was a problem hiding this comment.
Yes I think that'd be consistent
Member
Author
There was a problem hiding this comment.
Thanks, fixed. That was a typo.
Contributor
|
ACK b738799 Before: after: |
Contributor
|
concept ACK, utACK b738799 |
Also remove the hardly-readable nBits from UpdateTip's log message.
Member
Author
|
Fixed 0x%02x -> 0x%08x. |
Contributor
|
reACK eff736e |
laanwj
added a commit
that referenced
this pull request
Mar 31, 2016
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and also remove the hardly-readable nBits from UpdateTip's log message.
The decimal printing of block nVersion is not very readable in a versionbits world.