test_framework: detect failure of bitcoind startup #7744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
force-pushed
the
2016_03_detect_startup_failure
branch
2 times, most recently
from
f22f8ed to
8869c3b
Compare
This was referenced Mar 25, 2016
Member
Author
|
Not ready to merge yet. I've tested this with a -salvagewallet loop: Even though reporting is better, it still hangs after "Stopping nodes", going to investigate why. |
laanwj
force-pushed
the
2016_03_detect_startup_failure
branch
2 times, most recently
from
d4066d4 to
9c28f02
Compare
Member
Author
|
Should be fixed now. The problem was that start_nodes can fail with part of the nodes already started. |
Replace the `bitcoin-cli -rpcwait` after spawning bitcoind with our own loop that detects when bitcoind exits prematurely. And if one node fails to start, stop the others. This prevents a hang in such a case (see bitcoin#7463).
laanwj
force-pushed
the
2016_03_detect_startup_failure
branch
from
9c28f02 to
018b60c
Compare
Member
Author
|
|
| try: | ||
| for i in range(num_nodes): | ||
| rpcs.append(start_node(i, dirname, extra_args[i], rpchost, binary=binary[i])) | ||
| except: # If one node failed to start, stop the others |
Contributor
|
Good idea! |
Member
|
utACK 018b60c |
laanwj
added a commit
that referenced
this pull request
Mar 29, 2016
018b60c test_framework: detect failure of bitcoind startup (Wladimir J. van der Laan)
| return datadir | ||
|
|
||
| def rpc_url(i, rpchost=None): | ||
| return "http://rt:rt@%s:%d" % (rpchost or '127.0.0.1', rpc_port(i)) |
Member
There was a problem hiding this comment.
Nit: rpcbind_test.py no longer works after this.
Member
Author
There was a problem hiding this comment.
We should probably re-add that test to one of the standard sequence, otherwise it will just bitrot
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 9, 2016
Github-Pull: bitcoin#7744 Rebased-From: 018b60c
ftrader
added a commit
to ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu
that referenced
this pull request
Dec 9, 2016
This is a merge of bitcoin/bitcoin#7744 / MVF-Core PR#16. Instead of freezing up qa tests, wallet.py will fail on some 32-bit platforms where wallet salvage operation sometimes fails due to unknown reasons. See also: bitcoin/bitcoin#7463 about the -salvagewallet problem. Core has decided to disable the salvage part of the test in bitcoin/bitcoin#8038 , we may implement a Skip() of this test on 32-bit or disable that test step in a similar way. The wallet salvage problem is definitely unrelated to any fork programming.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 24, 2020
Backport RPC test harness PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6548 - bitcoin/bitcoin#6804 - Just the coverage backend, not the flag to enable it. - bitcoin/bitcoin#7744 - bitcoin/bitcoin#9832 - Excludes `wallet-hd.py` change (missing bitcoin/bitcoin#8309). Part of #2074.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 3, 2020
Backport RPC test harness PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6548 - bitcoin/bitcoin#6804 - Just the coverage backend, not the flag to enable it for all RPC tests. - bitcoin/bitcoin#7744 - bitcoin/bitcoin#9832 - Excludes `wallet-hd.py` change (missing bitcoin/bitcoin#8309). Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
bitcoin-cli -rpcwaitafter spawning bitcoind with our own loop that detects when bitcoind exits prematurely (before RPC is up).This prevents a hang in such a case (see #7463).