Skip to content

Conversation

@promag
Copy link
Contributor

@promag promag commented Mar 18, 2016

This change prevents double scanning the transaction hash when sorting COutPoint. Mostly relevant when COutPoint is the std::set or std::map key type.

@promag promag force-pushed the enhancement/improve-coutpoint-less-operator branch from bdac17a to 5ebf32c Compare March 18, 2016 04:19
src/uint256.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a and b are not available at this point. You might need to use other.data and data (self context).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, feeling stupid about copy&paste.. It was really late..

@promag promag force-pushed the enhancement/improve-coutpoint-less-operator branch from 5ebf32c to 0f17692 Compare March 18, 2016 08:04
@sipa
Copy link
Member

sipa commented Mar 20, 2016

ACK

@dcousens
Copy link
Contributor

utACK 0f17692

1 similar comment
@laanwj
Copy link
Member

laanwj commented Mar 21, 2016

utACK 0f17692

@laanwj laanwj merged commit 0f17692 into bitcoin:master Mar 21, 2016
laanwj added a commit that referenced this pull request Mar 21, 2016
0f17692 Improve COutPoint less operator (João Barbosa)
codablock pushed a commit to codablock/dash that referenced this pull request Dec 19, 2017
0f17692 Improve COutPoint less operator (João Barbosa)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants