tor: Change auth order to only use password auth if -torpassword #7703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
changed the title
src/torcontrol.cpp
Outdated
Member
There was a problem hiding this comment.
This seems a bit misleading: couldn't there be supported authentication mechanism left which we don't support? Suggestion: "Only supported remaining authenthentication mechanism left is password, but ..."
Member
Author
There was a problem hiding this comment.
Agreed, will change the message
Member
|
Concept ACK |
1 similar comment
Contributor
|
Concept ACK |
Change authentication order to make it more clear (see bitcoin#7700). - If the `-torpassword` option is provided, force use of `HASHEDPASSWORD` auth. - Give error message if `-torpassword` provided, but `HASHEDPASSWORD` auth is not available. - Give error message if only `HASHEDPASSWORD` available, but `-torpassword` not given.
laanwj
force-pushed
the
2016_03_auth_order
branch
from
8f5dcbc to
2e49448
Compare
Member
|
utACK 2e49448 |
laanwj
added a commit
that referenced
this pull request
Jun 8, 2016
…password 2e49448 tor: Change auth order to only use HASHEDPASSWORD if -torpassword (Wladimir J. van der Laan)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 26, 2017
Tor ephemeral hidden services Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6503 (included to reduce merge conflicts) - bitcoin/bitcoin#6639 - bitcoin/bitcoin#6643 - bitcoin/bitcoin#7090 - bitcoin/bitcoin#7035 - bitcoin/bitcoin#7170 - bitcoin/bitcoin#7218 (non-QT part) - bitcoin/bitcoin#7313 - bitcoin/bitcoin#7438 - bitcoin/bitcoin#7553 - bitcoin/bitcoin#7637 - bitcoin/bitcoin#7683 - bitcoin/bitcoin#7813 - bitcoin/bitcoin#7703 - bitcoin/bitcoin#8203 - bitcoin/bitcoin#9004 - bitcoin/bitcoin#9234 - bitcoin/bitcoin#9911 (partial) Closes #2061.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 22, 2017
…if -torpassword 2e49448 tor: Change auth order to only use HASHEDPASSWORD if -torpassword (Wladimir J. van der Laan)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…if -torpassword 2e49448 tor: Change auth order to only use HASHEDPASSWORD if -torpassword (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change authentication order to make it more clear, and make it possible to use password authentication even though the Tor instance supports cookie auth (see #7700).
Before:
-torpassword(if provided)After:
-torpasswordoption is provided, force use of password auth.-torpasswordprovided, but password auth is not available.-torpasswordnot given.