Skip to content

[qt] Remove 0-fee from send dialog #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Mar 17, 2016
Merged

[qt] Remove 0-fee from send dialog #7686

laanwj merged 2 commits into from
Mar 17, 2016

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Mar 14, 2016

This pull makes -sendfreetransactions a debug feature and removes it from the GUI. Nonetheless, it is still possible to set sendfreetransactions=$bool for the GUI via command line or config arg.

@laanwj
Copy link
Member

laanwj commented Mar 15, 2016

The previous proposal was to move this to the coin control window. But I'm fine with this too, as it's still settable on the command line.
utACK

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Mar 15, 2016

Agree with removing it because I don't think its useful to have it in the GUI. Will test...

@maflcko
Copy link
Member Author

maflcko commented Mar 15, 2016

It serves no purpose on mainnet, so there is no point in having it prominently in the GUI and confuse users.

jonasschnelli
jonasschnelli reviewed Mar 15, 2016
View reviewed changes
src/qt/forms/sendcoinsdialog.ui
<y>0</y>
<width>830</width>
<height>68</height>
<height>104</height>
Copy link
Contributor

@jonasschnelli jonasschnelli Mar 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for 104px height here? Is it because we have more space now for the scroll area? Currently, this gives some whitespace below the recipient-section-devider (bordered line).

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Mar 15, 2016

tested ACK fa48bb3

I'm happy to get rid of this checkbox which was setting a global state (fSendFreeTransactions) that also affects the RPC/Console interface.
Zero fee transactions could be reenabled over CoinControl, thought, allowing it only over RPC/Console is probably better.

@paveljanik
Copy link
Contributor

paveljanik commented Mar 15, 2016

ACK fa48bb3

@laanwj laanwj mentioned this pull request Mar 16, 2016
Closed
@jtimon
Copy link
Contributor

jtimon commented Mar 16, 2016

concept ACK

@laanwj
Copy link
Member

laanwj commented Mar 17, 2016

This leaves one instance of fSendFreeTransactions in src/qt/sendcoinsdialog.cpp

    if (!settings.contains("fSendFreeTransactions"))
        settings.setValue("fSendFreeTransactions", false);

@maflcko
Copy link
Member Author

maflcko commented Mar 17, 2016

@laanwj Good catch. Removed the dead code.

@laanwj
Copy link
Member

laanwj commented Mar 17, 2016

utACK fa48bb3

@laanwj laanwj merged commit fae8467 into bitcoin:master Mar 17, 2016
laanwj added a commit that referenced this pull request Mar 17, 2016
@laanwj
Merge #7686: [qt] Remove 0-fee from send dialog
f034bce 
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)
@maflcko maflcko deleted the Mf1603-qt-0-fee branch March 17, 2016 15:52
@maflcko maflcko mentioned this pull request Jun 29, 2016
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Dec 19, 2017
@laanwj @codablock
Merge bitcoin#7686: [qt] Remove 0-fee from send dialog
721171e 
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maflcko @laanwj @jonasschnelli @paveljanik @jtimon