Prevent multiple calls to CWallet::AvailableCoins #7649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice! Makes sense because in master, the current repetitive calls to |
Member
|
utACK d9668e7 |
Member
|
ACK |
src/wallet/wallet.cpp
Outdated
Member
There was a problem hiding this comment.
nit: please use std::vector for consistency and because we're striving to remove using namespace std at some point
Contributor
|
utACK besides @laanwj 's nit. |
promag
force-pushed
the
enhancement/prevent-multiple-calls-availablecoins
branch
from
d9668e7 to
bb16c88
Compare
Contributor
Author
|
@laanwj fixed nit and rebased. |
Contributor
|
utACK bb16c88 i like it! |
laanwj
added a commit
that referenced
this pull request
Mar 23, 2016
bb16c88 Prevent multiple calls to CWallet::AvailableCoins (João Barbosa)
ruimarinho
deleted the
enhancement/prevent-multiple-calls-availablecoins
branch
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
bb16c88 Prevent multiple calls to CWallet::AvailableCoins (João Barbosa)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CWallet::CreateTransactiongoes through several iterations to select the best coins and fee to fulfil the request. In each iteration the set of available coins is computed.This PR moves the computation of available coins to the begin and reuses it in each iteration.