Fix lockunspent help message #7646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK |
Contributor
|
utACK |
Member
|
utACK cf23442 |
src/wallet/rpcwallet.cpp
Outdated
Member
There was a problem hiding this comment.
This is not correct, I think.
Setting fAllowNull to true is different to allowing one or two arguments.
Member
|
Can you change this to just modify the help message, as the title implies? |
promag
force-pushed
the
support/fix-lockunspent-help-message
branch
from
cf23442 to
04b08c8
Compare
promag
force-pushed
the
support/fix-lockunspent-help-message
branch
from
04b08c8 to
df9e923
Compare
Contributor
Author
|
@laanwj fixed and rebased. |
laanwj
added a commit
that referenced
this pull request
Mar 23, 2016
df9e923 Fix lockunspents help message (João Barbosa)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
df9e923 Fix lockunspents help message (João Barbosa)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation allows the second parameter to be optional. In that case, and if unlock is true, all locked coins are unlocked.